b67c8970c9
bucket-handlers: fix missing return statement ( #2553 )
...
If the location was invalid, it would write an error response but then
continue to attempt to make the bucket. Whether or not it would succeed,
it would attempt to call response.WriteHeaders twice in a row, which
would cause a message to be logged to the server console (bad).
Here is the relevant Go code:
c80e0d374b/src/net/http/server.go (L878-L881)
8 years ago
418921de89
minor cleanup
...
- Reused contains() from utils.go at a couple of places
- Cleanup in return statements and boolean checks
8 years ago
ec4260d260
api: BucketNotification should disallow duplicate notification. ( #2539 )
...
Added checks to look for duplicated notification configs.
Fixes #2472
8 years ago
c39d3db7a0
server/tls: allocate tls.Config{} properly. ( #2537 )
...
There is a golang bug which crashes the server, allocate tls.Config properly to avoid
this problem.
```
2016/08/22 20:21:03 http: panic serving 127.0.0.1:40744: runtime error: invalid memory address or nil pointer dereference
goroutine 38 [running]:
net/http.(*conn).serve.func1(0xc820526680)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:1389 +0xc1
panic(0xbefa80, 0xc820010140)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/runtime/panic.go:443 +0x4e9
crypto/tls.(*Conn).serverHandshake(0xc820368300, 0x0, 0x0)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/crypto/tls/handshake_server.go:43 +0x4d6
crypto/tls.(*Conn).Handshake(0xc820368300, 0x0, 0x0)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/crypto/tls/conn.go:1035 +0x169
net/http.(*conn).serve(0xc820526680)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:1405 +0x382
created by net/http.(*Server).Serve
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:2137 +0x44e
```
Fixes #2536
8 years ago
2da0cfc904
signature: Use the client sent region if region is properly validated. ( #2534 )
...
A properly validated region string from the client should be once
validated properly.
Fixes #2521
8 years ago
9dd0e3dc44
config: Initialize notify for fresh configs. ( #2531 )
8 years ago
4722c94653
typo: Fix capitalization in heading. ( #2529 )
8 years ago
45c928e2f5
boot: checkPortAvailability() should fail only for EADDRINUSE error and ignore other errors. ( #2527 )
...
fixes #2510
8 years ago
07506358ff
Refactor Heal RPC and add Shutdown RPC ( #2488 )
8 years ago
975eb31973
api/bucketPolicy: Use minio-go/pkg/set and fix bucket policy regression. ( #2506 )
...
Current master has a regression 'mc policy <policy-type> alias/bucket/prefix'
does not work anymore, due to the way new minio-go changes do json marshalling.
This led to a regression on server side when a ``prefix`` is provided
policy is rejected as malformed from th server which is not the case with
AWS S3.
This patch uses the new ``minio-go/pkg/set`` package to address the
unmarshalling problems.
Fixes #2503
8 years ago
a3c509fd23
Doc: Modified examples in how-to-run-multiple-minio-server-instances-on-single-machine.md ( #2497 )
8 years ago
63bb78cfc6
Update README.md
8 years ago
f2fd8b0265
Adding test coverage for server-mux.go by creating TestListenAndServeTLS(). ( #2493 )
...
Editing config.go to add lock on customConfigPath to avoid race condition
when setGlobalConfigPath() and getConfigPath() are called concurrently.
8 years ago
a8052889fe
server-mux_test.go updating test to fix race condition with TestListenAndServe ( #2485 )
8 years ago
bccf549463
server: Move all the top level files into cmd folder. ( #2490 )
...
This change brings a change which was done for the 'mc'
package to allow for clean repo and have a cleaner
github drop in experience.
8 years ago
73d1a46f3e
Allow asterisk character in key names ( #2487 )
8 years ago
95c16f51cb
notification: Handle ARN with empty account and name types. ( #2482 )
...
Fixes #2481
8 years ago
810dcbf34b
fs: ListObjects should populate ETag properly if fs.json is available. ( #2480 )
...
Fixes #2470
8 years ago
cb77586508
controller: Fix controller cli arguments.
8 years ago
e2498edb45
contoller: Implement controlled healing and trigger ( #2381 )
...
This patch introduces new command line 'control'
- minio control
TO manage minio server connecting through GoRPC API frontend.
- minio control heal
Is implemented for healing objects.
8 years ago
0b7dfab17a
Refactoring MuxServer Close() method to always wait for conns to close before returning. Adding lock around ServerMux listener setting to protect against data race. Adding additional tests to server-mux_test.go to make sure open connections are closed and for ListenAndServe. ( #2467 )
8 years ago
674fdc4304
redirect-middleware: Redirect to /minio only if client is a browser and the request is not V4 signed. ( #2469 )
...
fixes #2356
8 years ago
10feb1af3f
tests: object handlers: Unit tests for Get and Copy Object handlers ( #2451 )
8 years ago
d2b924cca8
Added Goreportcard badge.
8 years ago
13390d0c95
tests: add tests for signature-v4.go ( #2458 )
...
This adds tests for the functions `doesPresignedSignatureMatch` and
`doesPolicySignatureMatch`.
8 years ago
0a3d43273f
vendor: sha256 32bit updated. ( #2459 )
8 years ago
4dec50ba51
build: Add platform specific fixes.
8 years ago
f2bffe6086
fs/delete-object: fs.json filepath was incorrect. ( #2448 )
8 years ago
8e2f64aea4
fs/multipart: save metadata(fs.json) for multipart uploads. ( #2450 )
8 years ago
c054e633fd
utils: Shutdown channel should be bufferred.
8 years ago
e86dfcf41e
api: Change listen bucket notification to be TopicConfiguration. ( #2447 )
8 years ago
3b9dbd748b
tests: Web handlers ( #2429 )
8 years ago
3d1bb8f439
tests: Fix hasExtendedHeader tests with env variable.
8 years ago
bb8a425d49
When updating the meta file, write to temp file first and then rename to the actual location.
...
This prevents appending the metadata to the metadata-file when a file is reuploaded.
8 years ago
0e745fdb05
fs: Enable fs.json with env MINIO_ENABLE_FSMETA
8 years ago
51d7749c3e
Check if eventN is initialized before notifying in Upload web handler ( #2435 )
8 years ago
76d56c6ff2
typo: Fix typos across the codebase. ( #2442 )
8 years ago
b41bfcbf2f
utils: Fix unit tests issue. ( #2441 )
8 years ago
341171f326
Problem: AWS documentation defines event timestamp as 1970-01-01T00:00:00.000Z ( #2440 )
...
While Minio is using 20160814T124605Z
(See http://docs.aws.amazon.com/AmazonS3/latest/dev/notification-content-structure.html )
Solution: adhere to AWS documentation
8 years ago
a3592228f5
bug-fix: fix for tests failure when cache is disabled ( #2439 )
8 years ago
5526ac13d2
Protect shutdown callbacks lists with a mutex ( #2432 )
8 years ago
9606cb9bcd
posix: Disk free verification should have relaxed handling of inodes. ( #2431 )
...
Some filesystems do not implement a way to provide total inodes available, instead inodes
are allocated based on available disk space. For example CephFS, StoreNext CVSFS, AzureFile
driver. Allow for the available disk to be separately validate and we will validate inodes
only if the total inodes are provided by the underlying filesystem.
Fixes #2364
8 years ago
7829ccea2c
Routing key was misspelled as routine key ( #2430 )
8 years ago
723153951c
Test api responses ( #2427 )
...
* Test List Multipart Uploads with correct max-keys
* Test List Objects V1 V2 with valid parameters
8 years ago
64dc2a2e7f
Heal format by inspection should avoid picking minioMetaBucket dir if the latter comes first in the list (listDir not ordered) ( #2426 )
8 years ago
fdab984c8d
Add test for fresh disks healing ( #2424 )
8 years ago
70fd38818e
clean up: ineffassign fixes ( #2411 )
8 years ago
ef0a108dde
Graceful shutdown for ServerMux ( #2341 )
8 years ago
0b225269e1
tests: posix: tests cleaning up and enhancing coverage. ( #2410 )
8 years ago
fe62688683
Add tests for Damerau Levenshtein algorithm ( #2407 )
8 years ago
Brendan Ashworth