34f2c5bcdf
verify before writing
...
merge
verify headers before writing
9 years ago
c784707ed8
Merge pull request #1233 from harshavardhana/bucket-policy
...
bucketpolicy: Improve bucket policy validation, avoid nested rules.
9 years ago
88714e7c8e
bucketpolicy: Improve bucket policy validation, avoid nested rules.
...
Bucket policy validation is more stricter now, to avoid nested
rules. The reason to do this is keep the rules simpler and more
meaningful avoiding conflicts.
This patch implements stricter checks.
Example policy to be generally avoided.
```
{
"Version": "2012-10-17",
"Statement": [
{
"Action": [
"s3:GetObject",
"s3:DeleteObject"
],
"Effect": "Allow",
"Principal": {
"AWS": [
"*"
]
},
"Resource": [
"arn:aws:s3:::jarjarbing/*"
]
},
{
"Action": [
"s3:GetObject",
"s3:DeleteObject"
],
"Effect": "Deny",
"Principal": {
"AWS": [
"*"
]
},
"Resource": [
"arn:aws:s3:::jarjarbing/restic/key/*"
]
}
]
}
```
9 years ago
2e3e164f16
Update Docker.md
9 years ago
15b5f4d7a3
Update Caddy.md
9 years ago
83f9a50137
Merge pull request #1229 from brendanashworth/improve-fs-getobject
...
pkg/fs: optimize GetObject, add benchmark
9 years ago
583e4ecff6
pkg/fs: optimize GetObject syscalls for common case
...
In the common case, GetObject is called on a bucket that exists and an
object that exists and is not a directory. It should be optimized for
this case, thus error-related syscalls are pushed back until they are
necessary.
This should not impact performance negatively in the uncommon case, and
instead drops two otherwise unnecessary os.Stat's in the common case.
The race conditions around a proper error being returned were present
beforehand.
It also renames 'err' to 'e'.
9 years ago
b2257682e4
pkg/fs: add benchmark for GetObject
...
This commit adds a benchmark for GetObject. It doesn't leverage the I/O
as much because it uses short text for data, just 58 chars.
9 years ago
09789de586
Merge branch 'awwalker-new-copy-headers'
9 years ago
9a5e3299fc
api/object: Add CopyObject to support match/modified copy headers
...
Adds support for the following request headers:
- x-amz-copy-source-if-match
- x-amz-copy-source-if-none-match
- x-amz-copy-source-if-unmodified-since
- x-amz-copy-source-if-modified-since
Fixes #1176
9 years ago
2c09df24ee
Merge pull request #1225 from hackintoshrao/fs-bucket-tests
...
tests: Add tests for ListBuckets
9 years ago
53a76439a2
test for GetBucketInfo
9 years ago
6b0af08885
Merge pull request #1224 from harshavardhana/simplify
...
cleanup: Remove unecessary packages and tests. Simplify.
9 years ago
5282a79eda
cleanup: Remove unecessary packages and tests. Simplify.
9 years ago
3d8b9afa8f
Merge pull request #1222 from harshavardhana/cleanup-fix
...
cleanup: Rename ObjectMetadata as ObjectInfo.
9 years ago
52751d81cb
cleanup: Rename ObjectMetadata as ObjectInfo.
...
Fixes #1215
9 years ago
c81f4b0228
Merge pull request #1218 from hackintoshrao/better-fs-util-test
...
Test: Better structuring of fs-utils test
9 years ago
ec8c1d4ef6
Better structuring of fs-utils test
9 years ago
b5c77b641d
Merge pull request #1209 from harshavardhana/err-naming
...
error: Add proper prefixes for s3Error codes.
9 years ago
fdf3d64793
error: Add proper prefixes for s3Error codes.
...
This patch adds 'Err' prefix for all standard API
error codes and also adds a proper type for them.
9 years ago
373d335d94
Merge pull request #1214 from brendanashworth/improve-listbuckets
...
ListBuckets test & improvement, IsValid{Bucket,Object}Name fix, test, docs
9 years ago
b16025abf4
Merge pull request #1213 from harshavardhana/presigned
...
auth: Detect anonymous as the last resort.
9 years ago
166ef09c3d
auth: Detect anonymous as the last resort.
9 years ago
e54aa10201
Merge pull request #1212 from harshavardhana/venodr
...
vendor: Update ui-assets with new changes and release.
9 years ago
5606232567
vendor: Update ui-assets with new changes and release.
9 years ago
9352cb87c6
Merge pull request #1211 from harshavardhana/vendorize
...
vendor: Add minio-go vendor updates.
9 years ago
e781959d5b
vendor: Add minio-go vendor updates.
9 years ago
af295f3600
Merge pull request #1186 from balamurugana/devel
...
api: refactor list object handling in fs backend
9 years ago
c70bc2209e
api: refactor list object handling in fs backend
...
When list object is invoked, it creates a goroutine if not available
for given parameters else uses existing goroutine. These goroutines
are alive for 15 seconds for further continuation list object request
else they exit.
Fixes #1076
9 years ago
5cb546d288
Merge pull request #1210 from krishnasrinivas/port-check-fix
...
startup: specify the network - tcp4/tcp6 for ListenTCP()
9 years ago
010e775b17
startup: specify the network - tcp4/tcp6 for ListenTCP()
9 years ago
2cba605514
Merge pull request #1206 from fwessels/notice-typo
...
Fix typo
9 years ago
d740d3aaae
Merge pull request #1208 from krishnasrinivas/port-check
...
startup: do not start minio server if port is not free. Fixes #1207
9 years ago
5ac4afa4d1
Merge pull request #1080 from harshavardhana/bucket-policy
...
accessPolicy: Implement Put, Get, Delete access policy.
9 years ago
ea7ea427ca
startup: do not start minio server if port is not free. Fixes #1207
9 years ago
027f7efbdb
Fix typo
9 years ago
d5057b3c51
accessPolicy: Implement Put, Get, Delete access policy.
...
This patch implements Get,Put,Delete bucket policies
Supporting - http://docs.aws.amazon.com/AmazonS3/latest/dev/access-policy-language-overview.html
Currently supports following actions.
"*": true,
"s3:*": true,
"s3:GetObject": true,
"s3:ListBucket": true,
"s3:PutObject": true,
"s3:CreateBucket": true,
"s3:GetBucketLocation": true,
"s3:DeleteBucket": true,
"s3:DeleteObject": true,
"s3:AbortMultipartUpload": true,
"s3:ListBucketMultipartUploads": true,
"s3:ListMultipartUploadParts": true,
following conditions for "StringEquals" and "StringNotEquals"
"s3:prefix", "s3:max-keys"
9 years ago
846410c563
Merge pull request #1205 from harshavardhana/patch-3
...
Fix docker documentation.
9 years ago
f268762ec7
Fix docker documentation.
9 years ago
41739e0913
Fix doc as per community member suggestion.
...
Added suggestion mentioned by our community member - fixes #1116
9 years ago
cd3eb63c4a
pkg/fs: test, document, and fix IsValid{Bucket,Object}Name
...
This commit improves the docs for both functions (more Go-like) and
drops an unnecessary condition in IsValidBucketName. This also drops a
condition in IsValidObjectName where "" (empty string) was a valid
object name. This has been fixed and will no longer return true.
This commit also adds tests for both functions, including a regression
test for the bug fix.
9 years ago
a5d0bef4e2
pkg/fs: test, bench, and drop unnecessary check in ListBuckets
...
There is now a simple test and a benchmark for ListBuckets. I also
dropped an unnecessary check that was simply repeated from above,
guaranteed to be true.
9 years ago
114f9de5eb
Merge pull request #1201 from harshavardhana/time
...
handlers: Cleanup time handler helpers.
9 years ago
761cb2c740
handlers: Cleanup time handlers helpers.
9 years ago
59fbb6d081
Merge pull request #1199 from brendanashworth/improvements-fs
...
pkg/fs improvements
9 years ago
fab45aae40
pkg/fs: add bucket test and benchmarks
...
Lots of useful benchmarks and a simple test addition!
9 years ago
7399d8ceaa
pkg/fs: skip unnecessary os.Stat system call
9 years ago
0a0451a0fb
pkg/fs: DRY SetBucketMetadata
...
It had a lot of code that was the same as GetBucketMetadata, so instead
call GBM from SBM so as to reduce doing the same thing in two different
spots. Theoretically this will induce a small overhead as now at least
two calls of denormalizeBucket are made, although this shouldn't be
noticeable.
9 years ago
294ea814bf
pkg/fs: for locks, prefer defer and read-only ops
...
This commit prefers the use of 'defer' for fs.Unlock (and fs.RUnlock)
because it is more idiomatic Go and reduces repetition in the code,
lending to a cleaner code base.
It also switches a few uses of the lock to read-only locks, which should
improve performance of those functions dramatically in certain contexts.
9 years ago
d54a8a9c07
Merge pull request #1195 from harshavardhana/delete-objects
...
api: Implement multiple objects Delete api - fixes #956
9 years ago
awwalker