posix: Support UNC paths on windows. (#1887)
This allows us to now use 32K paths names on windows. Fixes #1620master
parent
4ab57f7d60
commit
ed4fe689b4
@ -0,0 +1,56 @@ |
|||||||
|
/* |
||||||
|
* Minio Cloud Storage, (C) 2016 Minio, Inc. |
||||||
|
* |
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||||
|
* you may not use this file except in compliance with the License. |
||||||
|
* You may obtain a copy of the License at |
||||||
|
* |
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
* |
||||||
|
* Unless required by applicable law or agreed to in writing, software |
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS, |
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||||
|
* See the License for the specific language governing permissions and |
||||||
|
* limitations under the License. |
||||||
|
*/ |
||||||
|
|
||||||
|
package main |
||||||
|
|
||||||
|
import ( |
||||||
|
"path/filepath" |
||||||
|
"runtime" |
||||||
|
"strings" |
||||||
|
) |
||||||
|
|
||||||
|
// preparePath rewrites path to handle any OS specific details.
|
||||||
|
func preparePath(path string) string { |
||||||
|
if runtime.GOOS == "windows" { |
||||||
|
// Microsoft Windows supports long path names using
|
||||||
|
// uniform naming convention (UNC).
|
||||||
|
return UNCPath(path) |
||||||
|
} |
||||||
|
return path |
||||||
|
} |
||||||
|
|
||||||
|
// UNCPath converts a absolute windows path to a UNC long path.
|
||||||
|
func UNCPath(path string) string { |
||||||
|
// Clean the path for any trailing "/".
|
||||||
|
path = filepath.Clean(path) |
||||||
|
|
||||||
|
// UNC can NOT use "/", so convert all to "\".
|
||||||
|
path = filepath.FromSlash(path) |
||||||
|
|
||||||
|
// If prefix is "\\", we already have a UNC path or server.
|
||||||
|
if strings.HasPrefix(path, `\\`) { |
||||||
|
|
||||||
|
// If already long path, just keep it
|
||||||
|
if strings.HasPrefix(path, `\\?\`) { |
||||||
|
return path |
||||||
|
} |
||||||
|
|
||||||
|
// Trim "\\" from path and add UNC prefix.
|
||||||
|
return `\\?\UNC\` + strings.TrimPrefix(path, `\\`) |
||||||
|
} |
||||||
|
path = `\\?\` + path |
||||||
|
return path |
||||||
|
} |
@ -0,0 +1,37 @@ |
|||||||
|
/* |
||||||
|
* Minio Cloud Storage, (C) 2016 Minio, Inc. |
||||||
|
* |
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||||
|
* you may not use this file except in compliance with the License. |
||||||
|
* You may obtain a copy of the License at |
||||||
|
* |
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
* |
||||||
|
* Unless required by applicable law or agreed to in writing, software |
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS, |
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||||
|
* See the License for the specific language governing permissions and |
||||||
|
* limitations under the License. |
||||||
|
*/ |
||||||
|
|
||||||
|
package main |
||||||
|
|
||||||
|
import "strings" |
||||||
|
|
||||||
|
// List of reserved words for files, includes old and new ones.
|
||||||
|
var posixReservedPrefix = []string{ |
||||||
|
"$tmpfile", |
||||||
|
// Add new reserved words if any used in future.
|
||||||
|
} |
||||||
|
|
||||||
|
// hasPosixReservedPrefix - has reserved prefix.
|
||||||
|
func hasPosixReservedPrefix(name string) (isReserved bool) { |
||||||
|
for _, reservedKey := range posixReservedPrefix { |
||||||
|
if strings.HasPrefix(name, reservedKey) { |
||||||
|
isReserved = true |
||||||
|
break |
||||||
|
} |
||||||
|
isReserved = false |
||||||
|
} |
||||||
|
return isReserved |
||||||
|
} |
@ -0,0 +1,177 @@ |
|||||||
|
// +build windows
|
||||||
|
|
||||||
|
/* |
||||||
|
* Minio Cloud Storage, (C) 2016 Minio, Inc. |
||||||
|
* |
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||||
|
* you may not use this file except in compliance with the License. |
||||||
|
* You may obtain a copy of the License at |
||||||
|
* |
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
* |
||||||
|
* Unless required by applicable law or agreed to in writing, software |
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS, |
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||||
|
* See the License for the specific language governing permissions and |
||||||
|
* limitations under the License. |
||||||
|
*/ |
||||||
|
|
||||||
|
package main |
||||||
|
|
||||||
|
import ( |
||||||
|
"io" |
||||||
|
"os" |
||||||
|
"path/filepath" |
||||||
|
"strings" |
||||||
|
"syscall" |
||||||
|
"unicode/utf8" |
||||||
|
) |
||||||
|
|
||||||
|
const pathMax = 32 * 1024 // 32K is the maximum limit for UNC paths.
|
||||||
|
|
||||||
|
// isValidPath verifies if a path name is in accordance with FS limitations.
|
||||||
|
func isValidPath(path string) bool { |
||||||
|
if len(path) > pathMax || len(path) == 0 { |
||||||
|
return false |
||||||
|
} |
||||||
|
if !utf8.ValidString(path) { |
||||||
|
return false |
||||||
|
} |
||||||
|
return true |
||||||
|
} |
||||||
|
|
||||||
|
// isValidVolname verifies a volname name in accordance with object
|
||||||
|
// layer requirements.
|
||||||
|
func isValidVolname(volname string) bool { |
||||||
|
if len(volname) < 3 || len(volname) > 63 { |
||||||
|
return false |
||||||
|
} |
||||||
|
// Volname shouldn't have reserved characters on windows in it.
|
||||||
|
return !strings.ContainsAny(volname, "/\\:*?\"<>|") |
||||||
|
} |
||||||
|
|
||||||
|
// mkdirAll creates a directory named path,
|
||||||
|
// along with any necessary parents, and returns nil,
|
||||||
|
// or else returns an error. The permission bits perm are used
|
||||||
|
// for all directories that mkdirAll creates. If path is already
|
||||||
|
// a directory, mkdirAll does nothing and returns nil.
|
||||||
|
func mkdirAll(path string, perm os.FileMode) error { |
||||||
|
// Fast path: if we can tell whether path is a directory or file, stop with success or error.
|
||||||
|
dir, err := os.Stat(preparePath(path)) |
||||||
|
if err == nil { |
||||||
|
if dir.IsDir() { |
||||||
|
return nil |
||||||
|
} |
||||||
|
return &os.PathError{ |
||||||
|
Op: "mkdir", |
||||||
|
Path: path, |
||||||
|
Err: syscall.ENOTDIR, |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
// Slow path: make sure parent exists and then call Mkdir for path.
|
||||||
|
i := len(path) |
||||||
|
for i > 0 && os.IsPathSeparator(path[i-1]) { // Skip trailing path separator.
|
||||||
|
i-- |
||||||
|
} |
||||||
|
|
||||||
|
j := i |
||||||
|
for j > 0 && !os.IsPathSeparator(path[j-1]) { // Scan backward over element.
|
||||||
|
j-- |
||||||
|
} |
||||||
|
|
||||||
|
if j > 1 { |
||||||
|
// Create parent
|
||||||
|
parent := path[0 : j-1] |
||||||
|
if parent != filepath.VolumeName(parent) { |
||||||
|
err = mkdirAll(parent, perm) |
||||||
|
if err != nil { |
||||||
|
return err |
||||||
|
} |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
// Parent now exists; invoke Mkdir and use its result.
|
||||||
|
err = os.Mkdir(preparePath(path), perm) |
||||||
|
if err != nil { |
||||||
|
// Handle arguments like "foo/." by
|
||||||
|
// double-checking that directory doesn't exist.
|
||||||
|
dir, err1 := os.Lstat(preparePath(path)) |
||||||
|
if err1 == nil && dir.IsDir() { |
||||||
|
return nil |
||||||
|
} |
||||||
|
return err |
||||||
|
} |
||||||
|
return nil |
||||||
|
} |
||||||
|
|
||||||
|
// removeAll removes path and any children it contains.
|
||||||
|
// It removes everything it can but returns the first error
|
||||||
|
// it encounters. If the path does not exist, RemoveAll
|
||||||
|
// returns nil (no error).
|
||||||
|
func removeAll(path string) error { |
||||||
|
// Simple case: if Remove works, we're done.
|
||||||
|
err := os.Remove(preparePath(path)) |
||||||
|
if err == nil || os.IsNotExist(err) { |
||||||
|
return nil |
||||||
|
} |
||||||
|
|
||||||
|
// Otherwise, is this a directory we need to recurse into?
|
||||||
|
dir, serr := os.Lstat(preparePath(path)) |
||||||
|
if serr != nil { |
||||||
|
if serr, ok := serr.(*os.PathError); ok && (os.IsNotExist(serr.Err) || serr.Err == syscall.ENOTDIR) { |
||||||
|
return nil |
||||||
|
} |
||||||
|
return serr |
||||||
|
} |
||||||
|
if !dir.IsDir() { |
||||||
|
// Not a directory; return the error from Remove.
|
||||||
|
return err |
||||||
|
} |
||||||
|
|
||||||
|
// Directory.
|
||||||
|
fd, err := os.Open(preparePath(path)) |
||||||
|
if err != nil { |
||||||
|
if os.IsNotExist(err) { |
||||||
|
// Race. It was deleted between the Lstat and Open.
|
||||||
|
// Return nil per RemoveAll's docs.
|
||||||
|
return nil |
||||||
|
} |
||||||
|
return err |
||||||
|
} |
||||||
|
|
||||||
|
// Remove contents & return first error.
|
||||||
|
err = nil |
||||||
|
for { |
||||||
|
names, err1 := fd.Readdirnames(4096) // Get 4k entries.
|
||||||
|
for _, name := range names { |
||||||
|
err1 = removeAll(path + string(os.PathSeparator) + name) |
||||||
|
if err == nil { |
||||||
|
err = err1 |
||||||
|
} |
||||||
|
} |
||||||
|
if err1 == io.EOF { |
||||||
|
break |
||||||
|
} |
||||||
|
// If Readdirnames returned an error, use it.
|
||||||
|
if err == nil { |
||||||
|
err = err1 |
||||||
|
} |
||||||
|
if len(names) == 0 { |
||||||
|
break |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
// Close directory, because windows won't remove opened directory.
|
||||||
|
fd.Close() |
||||||
|
|
||||||
|
// Remove directory.
|
||||||
|
err1 := os.Remove(preparePath(path)) |
||||||
|
if err1 == nil || os.IsNotExist(err1) { |
||||||
|
return nil |
||||||
|
} |
||||||
|
if err == nil { |
||||||
|
err = err1 |
||||||
|
} |
||||||
|
return err |
||||||
|
} |
Loading…
Reference in new issue