Parallelize the DiskInfo calls in xl.StorageInfo() (#8115)

cmd/xl-sets.go

@@ -304,14 +304,26 @@ func newXLSets(endpoints EndpointList, format *formatXLV3, setCount int, drivesP
 // StorageInfo - combines output of StorageInfo across all erasure coded object sets.
 func (s *xlSets) StorageInfo(ctx context.Context) StorageInfo {
 	var storageInfo StorageInfo
+	var wg sync.WaitGroup
+
+	storageInfos := make([]StorageInfo, len(s.sets))
 	storageInfo.Backend.Type = BackendErasure
-	for _, set := range s.sets {
+	for index, set := range s.sets {
-		lstorageInfo := set.StorageInfo(ctx)
+		wg.Add(1)
-		storageInfo.Used = storageInfo.Used + lstorageInfo.Used
+		go func(id int, set *xlObjects) {
-		storageInfo.Total = storageInfo.Total + lstorageInfo.Total
+			defer wg.Done()
-		storageInfo.Available = storageInfo.Available + lstorageInfo.Available
+			storageInfos[id] = set.StorageInfo(ctx)
-		storageInfo.Backend.OnlineDisks = storageInfo.Backend.OnlineDisks + lstorageInfo.Backend.OnlineDisks
+		}(index, set)
-		storageInfo.Backend.OfflineDisks = storageInfo.Backend.OfflineDisks + lstorageInfo.Backend.OfflineDisks
+	}
+	// Wait for the go routines.
+	wg.Wait()
+
+	for _, lstorageInfo := range storageInfos {
+		storageInfo.Used += lstorageInfo.Used
+		storageInfo.Total += lstorageInfo.Total
+		storageInfo.Available += lstorageInfo.Available
+		storageInfo.Backend.OnlineDisks += lstorageInfo.Backend.OnlineDisks
+		storageInfo.Backend.OfflineDisks += lstorageInfo.Backend.OfflineDisks
 	}
 
 	scData, scParity := getRedundancyCount(standardStorageClass, s.drivesPerSet)

cmd/xl-v1.go

@@ -19,6 +19,7 @@ package cmd
 import (
 	"context"
 	"sort"
+	"sync"
 
 	"github.com/minio/minio/cmd/logger"
 	"github.com/minio/minio/pkg/bpool"
@@ -70,26 +71,32 @@ func (d byDiskTotal) Less(i, j int) bool {
 // getDisksInfo - fetch disks info across all other storage API.
 func getDisksInfo(disks []StorageAPI) (disksInfo []DiskInfo, onlineDisks int, offlineDisks int) {
 	disksInfo = make([]DiskInfo, len(disks))
+	var wg sync.WaitGroup
 	for i, storageDisk := range disks {
 		if storageDisk == nil {
 			// Storage disk is empty, perhaps ignored disk or not available.
 			offlineDisks++
 			continue
 		}
-		info, err := storageDisk.DiskInfo()
+		wg.Add(1)
-		if err != nil {
+		go func(id int, sDisk StorageAPI) {
-			ctx := context.Background()
+			defer wg.Done()
-			logger.GetReqInfo(ctx).AppendTags("disk", storageDisk.String())
+			info, err := sDisk.DiskInfo()
-			logger.LogIf(ctx, err)
+			if err != nil {
-			if IsErr(err, baseErrs...) {
+				reqInfo := (&logger.ReqInfo{}).AppendTags("disk", sDisk.String())
-				offlineDisks++
+				ctx := logger.SetReqInfo(context.Background(), reqInfo)
-				continue
+				logger.LogIf(ctx, err)
+				if IsErr(err, baseErrs...) {
+					offlineDisks++
+					return
+				}
 			}
-		}
+			onlineDisks++
-		onlineDisks++
+			disksInfo[id] = info
-		disksInfo[i] = info
+		}(i, storageDisk)
 	}
-
+	// Wait for the routines.
+	wg.Wait()
 	// Success.
 	return disksInfo, onlineDisks, offlineDisks
 }