If you do not have a working Golang environment setup please follow [Golang Installation Guide](https://docs.minio.io/docs/how-to-install-golang).
``Minio`` community welcomes your contribution. To make the process as seamless as possible, we recommend you read this contribution guide.
## Development Workflow
Start by forking the Minio GitHub repository, make changes in a branch and then send a pull request. We encourage pull requests to discuss code changes. Here are the steps in details:
### Setup your Minio Github Repository
### Setup your Minio Github Repository
Fork [Minio upstream](https://github.com/minio/minio/fork) source repository to your own personal repository. Copy the URL for minio from your personal github repo (you will need it for the `git clone` command below).
Fork [Minio upstream](https://github.com/minio/minio/fork) source repository to your own personal repository. Copy the URL of your Minio fork (you will need it for the `git clone` command below).
```sh
```sh
$ mkdir -p $GOPATH/src/github.com/minio
$ mkdir -p $GOPATH/src/github.com/minio
$ cd $GOPATH/src/github.com/minio
$ cd $GOPATH/src/github.com/minio
@ -11,61 +16,56 @@ $ git clone <paste saved URL for personal forked minio repo>
$ cd minio
$ cd minio
```
```
### Compiling Minio from source
### Set up git remote as ``upstream``
Minio uses ``Makefile`` to wrap around some of redundant checks done through command line.
```sh
$ make
Checking if proper environment variables are set.. Done
Checking if proper environment variables are set.. Done
...
Checking dependencies for Minio.. Done
Installed govet
Building Libraries
...
```
```
### Developer Guidelines
### Create your feature branch
``Minio`` community welcomes your contribution. To make the process as seamless as possible, we ask for the following:
Before making code changes, make sure you create a separate branch for these changes
* Go ahead and fork the project and make your changes. We encourage pull requests to discuss code changes.
- Fork it
```
- Create your feature branch (git checkout -b my-new-feature)
$ git checkout -b my-new-feature
- Commit your changes (git commit -am 'Add some feature')
```
- Push to the branch (git push origin my-new-feature)
- Create new Pull Request
### Test Minio server changes
After your code changes, make sure
* If you have additional dependencies for ``Minio``, ``Minio`` manages its dependencies using [govendor](https://github.com/kardianos/govendor)
- Run `go get foo/bar`
- To add test cases for the new code. If you have questions about how to do it, please ask on our [Slack](slack.minio.io) channel.
- Edit your code to import foo/bar
- To run `make verifiers`
- Run `make pkg-add PKG=foo/bar` from top-level directory
- To squash your commits into a single commit. `git rebase -i`. It's okay to force update your pull request.
- To run `go test -race ./...` and `go build` completes.
* If you have dependencies for ``Minio`` which needs to be removed
- Edit your code to not import foo/bar
### Commit changes
- Run `make pkg-remove PKG=foo/bar` from top-level directory
After verification, commit your changes. This is a [great post](https://chris.beams.io/posts/git-commit/) on how to write useful commit messages
* When you're ready to create a pull request, be sure to:
```
- Have test cases for the new code. If you have questions about how to do it, please ask in your pull request.
$ git commit -am 'Add some feature'
- Run `make verifiers`
```
- Squash your commits into a single commit. `git rebase -i`. It's okay to force update your pull request.
- Make sure `go test -race ./...` and `go build` completes.
### Push to the branch
Push your locally committed changes to the remote origin (your fork)
* Read [Effective Go](https://github.com/golang/go/wiki/CodeReviewComments) article from Golang project
```
- `Minio` project is fully conformant with Golang style
$ git push origin my-new-feature
- if you happen to observe offending code, please feel free to send a pull request
```
### Create a Pull Request
Pull requests can be created via GitHub. Refer to [this document](https://help.github.com/articles/creating-a-pull-request/) for detailed steps on how to create a pull request. After a Pull Request gets peer reviewed and approved, it will be merged.
## FAQs
### How does ``Minio`` manages dependencies?
``Minio`` manages its dependencies using [govendor](https://github.com/kardianos/govendor). To add a dependency
- Run `go get foo/bar`
- Edit your code to import foo/bar
- Run `make pkg-add PKG=foo/bar` from top-level directory
To remove a dependency
- Edit your code to not import foo/bar
- Run `make pkg-remove PKG=foo/bar` from top-level directory
### What are the coding guidelines for Minio?
``Minio`` is fully conformant with Golang style. Refer: [Effective Go](https://github.com/golang/go/wiki/CodeReviewComments) article from Golang project. If you observe offending code, please feel free to send a pull request or ping us on [Slack](slack.minio.io).
Nitish Tiwari
7 years ago
committed by