oyd
/
minio
6
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update DEVELOPER.md

Browse Source
master
Harshavardhana 10 years ago
parent 8088539c79
commit 62d56f4a62
1 changed files with 4 additions and 3 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 7
      DEVELOPER.md

7
DEVELOPER.md
Unescape View File

@ -35,6 +35,7 @@ Installed new-cmd into /home/userid/work/minio/gopath/bin
- Run `make save` from top-level directory (or `godep restore && godep save ./...`). - Run `make save` from top-level directory (or `godep restore && godep save ./...`).
* When you're ready to create a pull request, be sure to: * When you're ready to create a pull request, be sure to:
- Have test cases for the new code. If you have questions about how to do it, please ask in your pull request. - Have test cases for the new code. If you have questions about how to do it, please ask in your pull request.
- Run go fmt - Run `go fmt`
- Squash your commits into a single commit. git rebase -i. It's okay to force update your pull request. - Squash your commits into a single commit. `git rebase -i`. It's okay to force update your pull request.
- Make sure go test -race ./... passes, and go build completes. - Make sure `go test -race ./...` and `go build` completes.
* Make sure read Golang's [Code Review Comments](https://github.com/golang/go/wiki/CodeReviewComments) article, `Minio` project is strictly conformant with this style - if you happen to see an offending code, please feel free to send a pull request

Write Preview
Loading…
Cancel
Save