Add rootCAs support to Kafka & MQTT (#8236)

Fixes #8211
master
Praveen raj Mani 5 years ago committed by kannappanr
parent 696f4ceee2
commit 456ce4cc92
  1. 7
      cmd/config-current.go
  2. 6
      pkg/event/target/kafka.go

@ -341,6 +341,9 @@ func (s *serverConfig) TestNotificationTargets() error {
if !v.Enable { if !v.Enable {
continue continue
} }
if v.TLS.Enable {
v.TLS.RootCAs = globalRootCAs
}
t, err := target.NewKafkaTarget(k, v, GlobalServiceDoneCh) t, err := target.NewKafkaTarget(k, v, GlobalServiceDoneCh)
if err != nil { if err != nil {
return fmt.Errorf("kafka(%s): %s", k, err.Error()) return fmt.Errorf("kafka(%s): %s", k, err.Error())
@ -352,6 +355,7 @@ func (s *serverConfig) TestNotificationTargets() error {
if !v.Enable { if !v.Enable {
continue continue
} }
v.RootCAs = globalRootCAs
t, err := target.NewMQTTTarget(k, v, GlobalServiceDoneCh) t, err := target.NewMQTTTarget(k, v, GlobalServiceDoneCh)
if err != nil { if err != nil {
return fmt.Errorf("mqtt(%s): %s", k, err.Error()) return fmt.Errorf("mqtt(%s): %s", k, err.Error())
@ -690,6 +694,9 @@ func getNotificationTargets(config *serverConfig) *event.TargetList {
for id, args := range config.Notify.Kafka { for id, args := range config.Notify.Kafka {
if args.Enable { if args.Enable {
if args.TLS.Enable {
args.TLS.RootCAs = globalRootCAs
}
newTarget, err := target.NewKafkaTarget(id, args, GlobalServiceDoneCh) newTarget, err := target.NewKafkaTarget(id, args, GlobalServiceDoneCh)
if err != nil { if err != nil {
logger.LogIf(context.Background(), err) logger.LogIf(context.Background(), err)

@ -18,6 +18,7 @@ package target
import ( import (
"crypto/tls" "crypto/tls"
"crypto/x509"
"encoding/json" "encoding/json"
"errors" "errors"
"net" "net"
@ -40,6 +41,7 @@ type KafkaArgs struct {
QueueLimit uint64 `json:"queueLimit"` QueueLimit uint64 `json:"queueLimit"`
TLS struct { TLS struct {
Enable bool `json:"enable"` Enable bool `json:"enable"`
RootCAs *x509.CertPool `json:"-"`
SkipVerify bool `json:"skipVerify"` SkipVerify bool `json:"skipVerify"`
ClientAuth tls.ClientAuthType `json:"clientAuth"` ClientAuth tls.ClientAuthType `json:"clientAuth"`
} `json:"tls"` } `json:"tls"`
@ -198,7 +200,9 @@ func NewKafkaTarget(id string, args KafkaArgs, doneCh <-chan struct{}) (*KafkaTa
config.Net.TLS.Enable = args.TLS.Enable config.Net.TLS.Enable = args.TLS.Enable
tlsConfig := &tls.Config{ tlsConfig := &tls.Config{
ClientAuth: args.TLS.ClientAuth, ClientAuth: args.TLS.ClientAuth,
InsecureSkipVerify: args.TLS.SkipVerify,
RootCAs: args.TLS.RootCAs,
} }
config.Net.TLS.Config = tlsConfig config.Net.TLS.Config = tlsConfig

Loading…
Cancel
Save