increase drive OBD blocksize to 4MB (#9258)

master
Sidhartha Mani 5 years ago committed by GitHub
parent 3ea1be3c52
commit 44decbeae0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      pkg/disk/obd.go
  2. 7
      pkg/madmin/obd.go

@ -79,7 +79,7 @@ func GetOBDInfo(ctx context.Context, endpoint string) (Latency, Throughput, erro
// } // }
// } // }
blockSize := 1 * mb blockSize := 4 * mb
fileSize := 256 * mb fileSize := 256 * mb
latencies := make([]float64, fileSize/blockSize) latencies := make([]float64, fileSize/blockSize)

@ -236,6 +236,7 @@ func (adm *AdminClient) ServerOBDInfo(ctx context.Context, obdDataTypes []OBDDat
v.Set(string(d), "true") v.Set(string(d), "true")
} }
var OBDInfoMessage OBDInfo var OBDInfoMessage OBDInfo
OBDInfoMessage.TimeStamp = time.Now()
if v.Get(string(OBDDataTypeMinioInfo)) == "true" { if v.Get(string(OBDDataTypeMinioInfo)) == "true" {
info, err := adm.ServerInfo(ctx) info, err := adm.ServerInfo(ctx)
@ -259,8 +260,10 @@ func (adm *AdminClient) ServerOBDInfo(ctx context.Context, obdDataTypes []OBDDat
respChan <- OBDInfo{ respChan <- OBDInfo{
Error: err.Error(), Error: err.Error(),
} }
close(respChan)
return return
} }
// Check response http status code // Check response http status code
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
respChan <- OBDInfo{ respChan <- OBDInfo{
@ -268,10 +271,13 @@ func (adm *AdminClient) ServerOBDInfo(ctx context.Context, obdDataTypes []OBDDat
} }
return return
} }
// Unmarshal the server's json response // Unmarshal the server's json response
decoder := json.NewDecoder(resp.Body) decoder := json.NewDecoder(resp.Body)
for { for {
err := decoder.Decode(&OBDInfoMessage) err := decoder.Decode(&OBDInfoMessage)
OBDInfoMessage.TimeStamp = time.Now()
if err == io.EOF { if err == io.EOF {
break break
} }
@ -283,7 +289,6 @@ func (adm *AdminClient) ServerOBDInfo(ctx context.Context, obdDataTypes []OBDDat
respChan <- OBDInfoMessage respChan <- OBDInfoMessage
} }
OBDInfoMessage.TimeStamp = time.Now()
respChan <- OBDInfoMessage respChan <- OBDInfoMessage
close(respChan) close(respChan)
}() }()

Loading…
Cancel
Save