fix: [minor] Avoid unnecessary typecasting. (#4828)

We don't need to typecast identifiers from
their base to type to same type again. This
is not a bug and compiler is fine to skip
it but it is better to avoid if not needed.

cmd/erasure-readfile.go

@@ -75,8 +75,8 @@ func (s ErasureStorage) ReadFile(writer io.Writer, volume, path string, offset,
 			return f, err
 		}
 		startOffset = 0
-		f.Size += int64(n)
+		f.Size += n
-		length -= int64(n)
+		length -= n
 	}
 
 	f.Algorithm = algorithm

cmd/signature-v4.go

@@ -238,13 +238,13 @@ func doesPresignedSignatureMatch(hashedPayload string, r *http.Request, region s
 		return ErrRequestNotReadyYet
 	}
 
-	if UTCNow().Sub(pSignValues.Date) > time.Duration(pSignValues.Expires) {
+	if UTCNow().Sub(pSignValues.Date) > pSignValues.Expires {
 		return ErrExpiredPresignRequest
 	}
 
 	// Save the date and expires.
 	t := pSignValues.Date
-	expireSeconds := int(time.Duration(pSignValues.Expires) / time.Second)
+	expireSeconds := int(pSignValues.Expires / time.Second)
 
 	// Construct the query.
 	query.Set("X-Amz-Date", t.Format(iso8601Format))

cmd/xl-v1-object.go

@@ -571,7 +571,7 @@ func (xl xlObjects) PutObject(bucket string, object string, size int64, data io.
 
 		// Should return IncompleteBody{} error when reader has fewer bytes
 		// than specified in request header.
-		if file.Size < int64(curPartSize) {
+		if file.Size < curPartSize {
 			return ObjectInfo{}, traceError(IncompleteBody{})
 		}
 

cmd/xl-v1-utils.go

@@ -117,7 +117,7 @@ func hashOrder(key string, cardinality int) []int {
 	nums := make([]int, cardinality)
 	keyCrc := crc32.Checksum([]byte(key), crc32.IEEETable)
 
-	start := int(uint32(keyCrc)%uint32(cardinality)) | 1
+	start := int(keyCrc%uint32(cardinality)) | 1
 	for i := 1; i <= cardinality; i++ {
 		nums[i-1] = 1 + ((start + i) % cardinality)
 	}