server: http.Server do not add deadlines causes issues. (#2581)

Adding deadlines is a no go since Golang doesn't back off
the timers if there is an active i/o in progress.

It is meant to be for applications to handle this themselves
and manually progress the deadlines.

Fixes #2561
master
Harshavardhana 8 years ago committed by GitHub
parent 7431acb2c4
commit 2020afd200
  1. 6
      cmd/server-mux.go

@ -188,9 +188,9 @@ func NewMuxServer(addr string, handler http.Handler) *MuxServer {
m := &MuxServer{ m := &MuxServer{
Server: http.Server{ Server: http.Server{
Addr: addr, Addr: addr,
// Adding timeout of 10 minutes for unresponsive client connections. // Do not add any timeouts Golang net.Conn
ReadTimeout: 10 * time.Minute, // closes connections right after 10mins even
WriteTimeout: 10 * time.Minute, // if they are not idle.
Handler: handler, Handler: handler,
MaxHeaderBytes: 1 << 20, MaxHeaderBytes: 1 << 20,
}, },

Loading…
Cancel
Save