The musl compatibility patches are now included in the upstream version. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>master
parent
75c5ab4caf
commit
e7c179326a
@ -1,147 +0,0 @@ |
|||||||
From c6bdd0d302119819de72439972d0462c26ef9eda Mon Sep 17 00:00:00 2001
|
|
||||||
From: Felix Janda <felix.janda@posteo.de>
|
|
||||||
Date: Sun, 12 Nov 2017 13:30:17 -0500
|
|
||||||
Subject: uapi libc compat: add fallback for unsupported libcs
|
|
||||||
|
|
||||||
libc-compat.h aims to prevent symbol collisions between uapi and libc
|
|
||||||
headers for each supported libc. This requires continuous coordination
|
|
||||||
between them.
|
|
||||||
|
|
||||||
The goal of this commit is to improve the situation for libcs (such as
|
|
||||||
musl) which are not yet supported and/or do not wish to be explicitly
|
|
||||||
supported, while not affecting supported libcs. More precisely, with
|
|
||||||
this commit, unsupported libcs can request the suppression of any
|
|
||||||
specific uapi definition by defining the correspondings _UAPI_DEF_*
|
|
||||||
macro as 0. This can fix symbol collisions for them, as long as the
|
|
||||||
libc headers are included before the uapi headers. Inclusion in the
|
|
||||||
other order is outside the scope of this commit.
|
|
||||||
|
|
||||||
All infrastructure in order to enable this fallback for unsupported
|
|
||||||
libcs is already in place, except that libc-compat.h unconditionally
|
|
||||||
defines all _UAPI_DEF_* macros to 1 for all unsupported libcs so that
|
|
||||||
any previous definitions are ignored. In order to fix this, this commit
|
|
||||||
merely makes these definitions conditional.
|
|
||||||
|
|
||||||
This commit together with the musl libc commit
|
|
||||||
|
|
||||||
http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258
|
|
||||||
|
|
||||||
fixes for example the following compiler errors when <linux/in6.h> is
|
|
||||||
included after musl's <netinet/in.h>:
|
|
||||||
|
|
||||||
./linux/in6.h:32:8: error: redefinition of 'struct in6_addr'
|
|
||||||
./linux/in6.h:49:8: error: redefinition of 'struct sockaddr_in6'
|
|
||||||
./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq'
|
|
||||||
|
|
||||||
The comments referencing glibc are still correct, but this file is not
|
|
||||||
only used for glibc any more.
|
|
||||||
|
|
||||||
Signed-off-by: Felix Janda <felix.janda@posteo.de>
|
|
||||||
Reviewed-by: Hauke Mehrtens <hauke@hauke-m.de>
|
|
||||||
---
|
|
||||||
include/uapi/linux/libc-compat.h | 55 +++++++++++++++++++++++++++++++++++++++-
|
|
||||||
1 file changed, 54 insertions(+), 1 deletion(-)
|
|
||||||
|
|
||||||
--- a/include/uapi/linux/libc-compat.h
|
|
||||||
+++ b/include/uapi/linux/libc-compat.h
|
|
||||||
@@ -168,46 +168,99 @@
|
|
||||||
|
|
||||||
/* If we did not see any headers from any supported C libraries,
|
|
||||||
* or we are being included in the kernel, then define everything
|
|
||||||
- * that we need. */
|
|
||||||
+ * that we need. Check for previous __UAPI_* definitions to give
|
|
||||||
+ * unsupported C libraries a way to opt out of any kernel definition. */
|
|
||||||
#else /* !defined(__GLIBC__) */
|
|
||||||
|
|
||||||
/* Definitions for if.h */
|
|
||||||
+#ifndef __UAPI_DEF_IF_IFCONF
|
|
||||||
#define __UAPI_DEF_IF_IFCONF 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IF_IFMAP
|
|
||||||
#define __UAPI_DEF_IF_IFMAP 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IF_IFNAMSIZ
|
|
||||||
#define __UAPI_DEF_IF_IFNAMSIZ 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IF_IFREQ
|
|
||||||
#define __UAPI_DEF_IF_IFREQ 1
|
|
||||||
+#endif
|
|
||||||
/* Everything up to IFF_DYNAMIC, matches net/if.h until glibc 2.23 */
|
|
||||||
+#ifndef __UAPI_DEF_IF_NET_DEVICE_FLAGS
|
|
||||||
#define __UAPI_DEF_IF_NET_DEVICE_FLAGS 1
|
|
||||||
+#endif
|
|
||||||
/* For the future if glibc adds IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO */
|
|
||||||
+#ifndef __UAPI_DEF_IF_NET_DEVICE_FLAGS_LOWER_UP_DORMANT_ECHO
|
|
||||||
#define __UAPI_DEF_IF_NET_DEVICE_FLAGS_LOWER_UP_DORMANT_ECHO 1
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
/* Definitions for in.h */
|
|
||||||
+#ifndef __UAPI_DEF_IN_ADDR
|
|
||||||
#define __UAPI_DEF_IN_ADDR 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IN_IPPROTO
|
|
||||||
#define __UAPI_DEF_IN_IPPROTO 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IN_PKTINFO
|
|
||||||
#define __UAPI_DEF_IN_PKTINFO 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IP_MREQ
|
|
||||||
#define __UAPI_DEF_IP_MREQ 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_SOCKADDR_IN
|
|
||||||
#define __UAPI_DEF_SOCKADDR_IN 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IN_CLASS
|
|
||||||
#define __UAPI_DEF_IN_CLASS 1
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
/* Definitions for in6.h */
|
|
||||||
+#ifndef __UAPI_DEF_IN6_ADDR
|
|
||||||
#define __UAPI_DEF_IN6_ADDR 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IN6_ADDR_ALT
|
|
||||||
#define __UAPI_DEF_IN6_ADDR_ALT 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_SOCKADDR_IN6
|
|
||||||
#define __UAPI_DEF_SOCKADDR_IN6 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPV6_MREQ
|
|
||||||
#define __UAPI_DEF_IPV6_MREQ 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPPROTO_V6
|
|
||||||
#define __UAPI_DEF_IPPROTO_V6 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPV6_OPTIONS
|
|
||||||
#define __UAPI_DEF_IPV6_OPTIONS 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IN6_PKTINFO
|
|
||||||
#define __UAPI_DEF_IN6_PKTINFO 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IP6_MTUINFO
|
|
||||||
#define __UAPI_DEF_IP6_MTUINFO 1
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
/* Definitions for ipx.h */
|
|
||||||
+#ifndef __UAPI_DEF_SOCKADDR_IPX
|
|
||||||
#define __UAPI_DEF_SOCKADDR_IPX 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPX_ROUTE_DEFINITION
|
|
||||||
#define __UAPI_DEF_IPX_ROUTE_DEFINITION 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPX_INTERFACE_DEFINITION
|
|
||||||
#define __UAPI_DEF_IPX_INTERFACE_DEFINITION 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPX_CONFIG_DATA
|
|
||||||
#define __UAPI_DEF_IPX_CONFIG_DATA 1
|
|
||||||
+#endif
|
|
||||||
+#ifndef __UAPI_DEF_IPX_ROUTE_DEF
|
|
||||||
#define __UAPI_DEF_IPX_ROUTE_DEF 1
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
/* Definitions for xattr.h */
|
|
||||||
+#ifndef __UAPI_DEF_XATTR
|
|
||||||
#define __UAPI_DEF_XATTR 1
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
#endif /* __GLIBC__ */
|
|
||||||
|
|
@ -1,55 +0,0 @@ |
|||||||
From 649affd04813c43e0a72886517fcfccd63230981 Mon Sep 17 00:00:00 2001
|
|
||||||
From: Hauke Mehrtens <hauke@hauke-m.de>
|
|
||||||
Date: Mon, 29 Jun 2015 16:53:03 +0200
|
|
||||||
Subject: uapi/if_ether.h: prevent redefinition of struct ethhdr
|
|
||||||
|
|
||||||
Musl provides its own ethhdr struct definition. Add a guard to prevent
|
|
||||||
its definition of the appropriate musl header has already been included.
|
|
||||||
|
|
||||||
glibc does not implement this header, but when glibc will implement this
|
|
||||||
they can just define __UAPI_DEF_ETHHDR 0 to make it work with the
|
|
||||||
kernel.
|
|
||||||
|
|
||||||
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
|
|
||||||
---
|
|
||||||
include/uapi/linux/if_ether.h | 3 +++
|
|
||||||
include/uapi/linux/libc-compat.h | 6 ++++++
|
|
||||||
2 files changed, 9 insertions(+)
|
|
||||||
|
|
||||||
--- a/include/uapi/linux/if_ether.h
|
|
||||||
+++ b/include/uapi/linux/if_ether.h
|
|
||||||
@@ -23,6 +23,7 @@
|
|
||||||
#define _LINUX_IF_ETHER_H
|
|
||||||
|
|
||||||
#include <linux/types.h>
|
|
||||||
+#include <linux/libc-compat.h>
|
|
||||||
|
|
||||||
/*
|
|
||||||
* IEEE 802.3 Ethernet magic constants. The frame sizes omit the preamble
|
|
||||||
@@ -149,11 +150,13 @@
|
|
||||||
* This is an Ethernet frame header.
|
|
||||||
*/
|
|
||||||
|
|
||||||
+#if __UAPI_DEF_ETHHDR
|
|
||||||
struct ethhdr {
|
|
||||||
unsigned char h_dest[ETH_ALEN]; /* destination eth addr */
|
|
||||||
unsigned char h_source[ETH_ALEN]; /* source ether addr */
|
|
||||||
__be16 h_proto; /* packet type ID field */
|
|
||||||
} __attribute__((packed));
|
|
||||||
+#endif
|
|
||||||
|
|
||||||
|
|
||||||
#endif /* _LINUX_IF_ETHER_H */
|
|
||||||
--- a/include/uapi/linux/libc-compat.h
|
|
||||||
+++ b/include/uapi/linux/libc-compat.h
|
|
||||||
@@ -264,4 +264,10 @@
|
|
||||||
|
|
||||||
#endif /* __GLIBC__ */
|
|
||||||
|
|
||||||
+/* Definitions for if_ether.h */
|
|
||||||
+/* allow libcs like musl to deactivate this, glibc does not implement this. */
|
|
||||||
+#ifndef __UAPI_DEF_ETHHDR
|
|
||||||
+#define __UAPI_DEF_ETHHDR 1
|
|
||||||
+#endif
|
|
||||||
+
|
|
||||||
#endif /* _LIBC_COMPAT_H */
|
|
Loading…
Reference in new issue