Refactor privacyPrefence() to use priority list (#7945)

app/javascript/mastodon/reducers/compose.js

@@ -151,15 +151,8 @@ const insertEmoji = (state, position, emojiData, needsSpace) => {
 };
 
 const privacyPreference = (a, b) => {
-  if (a === 'direct' || b === 'direct') {
+  const order = ['public', 'unlisted', 'private', 'direct'];
-    return 'direct';
+  return order[Math.max(order.indexOf(a), order.indexOf(b), 0)];
-  } else if (a === 'private' || b === 'private') {
-    return 'private';
-  } else if (a === 'unlisted' || b === 'unlisted') {
-    return 'unlisted';
-  } else {
-    return 'public';
-  }
 };
 
 const hydrate = (state, hydratedState) => {