Fix wrong person being notified after nested reblog call, fix favourites leaking private toots in Atom feeds

master
Eugen Rochko 7 years ago
parent e2c2fefc36
commit 8b94d283fb
  1. 4
      app/models/favourite.rb
  2. 4
      app/services/reblog_service.rb

@ -29,6 +29,10 @@ class Favourite < ApplicationRecord
thread thread
end end
def hidden?
status.private_visibility?
end
before_validation do before_validation do
self.status = status.reblog if status.reblog? self.status = status.reblog if status.reblog?
end end

@ -14,9 +14,9 @@ class ReblogService < BaseService
Pubsubhubbub::DistributionWorker.perform_async(reblog.stream_entry.id) Pubsubhubbub::DistributionWorker.perform_async(reblog.stream_entry.id)
if reblogged_status.local? if reblogged_status.local?
NotifyService.new.call(reblogged_status.account, reblog) NotifyService.new.call(reblog.reblog.account, reblog)
else else
NotificationWorker.perform_async(reblog.stream_entry.id, reblogged_status.account_id) NotificationWorker.perform_async(reblog.stream_entry.id, reblog.reblog.account_id)
end end
reblog reblog

Loading…
Cancel
Save