Change detailed status child ordering to sort self-replies on top (#11686)

Fixes #11679

app/javascript/mastodon/features/status/index.js

@@ -84,28 +84,38 @@ const makeMapStateToProps = () => {
   const getDescendantsIds = createSelector([
     (_, { id }) => id,
     state => state.getIn(['contexts', 'replies']),
-  ], (statusId, contextReplies) => {
+    state => state.get('statuses'),
-    let descendantsIds = Immutable.List();
+  ], (statusId, contextReplies, statuses) => {
-    descendantsIds = descendantsIds.withMutations(mutable => {
+    let descendantsIds = [];
-      const ids = [statusId];
+    const ids = [statusId];
 
-      while (ids.length > 0) {
+    while (ids.length > 0) {
-        let id        = ids.shift();
+      let id        = ids.shift();
-        const replies = contextReplies.get(id);
+      const replies = contextReplies.get(id);
 
-        if (statusId !== id) {
+      if (statusId !== id) {
-          mutable.push(id);
+        descendantsIds.push(id);
-        }
+      }
 
-        if (replies) {
+      if (replies) {
-          replies.reverse().forEach(reply => {
+        replies.reverse().forEach(reply => {
-            ids.unshift(reply);
+          ids.unshift(reply);
-          });
+        });
-        }
       }
-    });
+    }
+
+    let insertAt = descendantsIds.findIndex((id) => statuses.get(id).get('in_reply_to_account_id') !== statuses.get(id).get('account'));
+    if (insertAt !== -1) {
+      descendantsIds.forEach((id, idx) => {
+        if (idx > insertAt && statuses.get(id).get('in_reply_to_account_id') === statuses.get(id).get('account')) {
+          descendantsIds.splice(idx, 1);
+          descendantsIds.splice(insertAt, 0, id);
+          insertAt += 1;
+        }
+      });
+    }
 
-    return descendantsIds;
+    return Immutable.List(descendantsIds);
   });
 
   const mapStateToProps = (state, props) => {