Don't send Link header when don't know prev and next links (#4633)

master
Yamagishi Kazutoshi 7 years ago committed by Eugen Rochko
parent 4edf9d849f
commit 2edfdab6e6
  1. 2
      app/controllers/api/base_controller.rb
  2. 3
      spec/controllers/api/v1/favourites_controller_spec.rb

@ -43,7 +43,7 @@ class Api::BaseController < ApplicationController
links = [] links = []
links << [next_path, [%w(rel next)]] if next_path links << [next_path, [%w(rel next)]] if next_path
links << [prev_path, [%w(rel prev)]] if prev_path links << [prev_path, [%w(rel prev)]] if prev_path
response.headers['Link'] = LinkHeader.new(links) response.headers['Link'] = LinkHeader.new(links) unless links.empty?
end end
def limit_param(default_limit) def limit_param(default_limit)

@ -70,8 +70,7 @@ RSpec.describe Api::V1::FavouritesController, type: :controller do
it 'does not add pagination headers if not necessary' do it 'does not add pagination headers if not necessary' do
get :index get :index
expect(response.headers['Link'].find_link(['rel', 'next'])).to eq nil expect(response.headers['Link']).to eq nil
expect(response.headers['Link'].find_link(['rel', 'prev'])).to eq nil
end end
end end
end end

Loading…
Cancel
Save