7 Commits (e2498edb4580b6c941b70f2c480de90fa08dd867)

Author	SHA1	Message	Date
Harshavardhana	d1bb8a5b21	api: refactor the bucket policy reading and writing. (#2395) ... Policies are read once during server startup and subsequently managed through in memory map. In-memory map is updated as and when there are new changes coming in.	8 years ago
karthic rao	48aa5f2199	api/bucket-policy: Add unit tests for more coverage, fixes couple of bugs. (#2055) ... Changes to ResourceMatch logic. Test for action match function.	8 years ago
Aakash Muttineni	6f3bd76754	api: Add new bucket policy nesting error (#1883) ... * Added ErrPolicyNesting which is returned when nesting of policies has occured * Replaces ErrMalformedPolicy in the case of nesting * Changed test case in bucket-policy-parser_test.go (ErrMalformedPolicy -> ErrPolicyNesting)	8 years ago
Harshavardhana	ba5805e60a	bucketPolicy: Do not use regexes, just do prefix matches. (#1497) ... AWS arn supports wildcards and this is flat namespace, simple prefix matching is fine. Fixes #1481 Fixes #1482	9 years ago
karthic rao	188bb92d8a	bucket-policy parset tests, and bug fixes (#1317)	9 years ago
Harshavardhana	996d2e2a10	bucketpolicy: checkBucketPolicy should keep resources in map. ... This is done to make sure to avoid appending duplicates for resources for each actions.	9 years ago
Harshavardhana	88714e7c8e	bucketpolicy: Improve bucket policy validation, avoid nested rules. ... Bucket policy validation is more stricter now, to avoid nested rules. The reason to do this is keep the rules simpler and more meaningful avoiding conflicts. This patch implements stricter checks. Example policy to be generally avoided. ``` { "Version": "2012-10-17", "Statement": [ { "Action": [ "s3:GetObject", "s3:DeleteObject" ], "Effect": "Allow", "Principal": { "AWS": [ "*" ] }, "Resource": [ "arn:aws:s3:::jarjarbing/*" ] }, { "Action": [ "s3:GetObject", "s3:DeleteObject" ], "Effect": "Deny", "Principal": { "AWS": [ "*" ] }, "Resource": [ "arn:aws:s3:::jarjarbing/restic/key/*" ] } ] } ```	9 years ago
Harshavardhana	d5057b3c51	accessPolicy: Implement Put, Get, Delete access policy. ... This patch implements Get,Put,Delete bucket policies Supporting - http://docs.aws.amazon.com/AmazonS3/latest/dev/access-policy-language-overview.html Currently supports following actions. "*": true, "s3:*": true, "s3:GetObject": true, "s3:ListBucket": true, "s3:PutObject": true, "s3:CreateBucket": true, "s3:GetBucketLocation": true, "s3:DeleteBucket": true, "s3:DeleteObject": true, "s3:AbortMultipartUpload": true, "s3:ListBucketMultipartUploads": true, "s3:ListMultipartUploadParts": true, following conditions for "StringEquals" and "StringNotEquals" "s3:prefix", "s3:max-keys"	9 years ago