Harshavardhana
afe874f15a
api: CopyObject pipe should be closed pro-actively upon error. ( #2625 )
...
Fixes a deadlock reproduced while running s3verify during
RemoveObject(). Previously held lock by GetObject() inside
the go-routine was never relenquished.
8 years ago
Harshavardhana
b291dbe9c5
s3: Fix compliance bugs reported by s3verify. ( #2624 )
...
- Fixes couple of error strings reported are mismatching.
- Fixes a error HTTP status which was wrong fixed.
- Remove usage of an deprecated PostResponse, au contraire
to their documentation there is no response body in
PostPolicy.
8 years ago
Harshavardhana
bc8f34bfe7
server/mux: Remove unused waitgroup from listenerMux. ( #2614 )
...
Change struct names to be more meaningful.
8 years ago
Harshavardhana
2dc7ecc59b
notifications: Fix bucket notifications for DeleteMultipleObjects. ( #2609 )
...
Now reports bucket notifications for DeleteMultipleObjects API.
Also deletes multiple objects in parallel.
8 years ago
Hugo Jobling
600551feb9
Make export directory an exposed volume ( #2610 )
...
This exposes the /export directory, making it possible to mount it from other
containers. It also makes it possible to bind a local folder to the internal /export
mount point using the native Docker for Mac/Windows and Kinematic.
8 years ago
Harshavardhana
7398d737b5
profiler: Fix it properly and generate/save profiles even failure situations. ( #2607 )
...
Fixes #2594
8 years ago
Harshavardhana
bf62ba57cf
docs: Update minimum drives in erasure docs.
8 years ago
Harshavardhana
511a8cbe04
profiler: Fix how we generate profiles. ( #2596 )
...
Fixes #2594
8 years ago
koolhead17
790ad68d4d
Doc: Fixed Minio install steps from source. ( #2590 )
8 years ago
Anis Elleuch
e79d2381fc
Fix rare 'go test -race' failure in ListenServe{Plain,TLS} ( #2588 )
8 years ago
Krishna Srinivas
a3b4199e9b
FS/Multipart: Allow for parallel uploads of parts with same part number. ( #2587 )
...
CBL client does not close connection when the backup process is stopped, this causes
read() on the stream on the server side to block and hence the lock held on the part
is not released. When the backup process is restarted, we again try to lock on the
part and this will block. Using a unique tmp name and not locking it fixes the problem.
8 years ago
Krishna Srinivas
3aa0574c6b
FS/multipart: Append the parts to a file as and when the parts arrive. ( #2513 )
8 years ago
Andrew Stone
3118195e92
docker: Minimize image size ( #2585 )
...
This takes the image size from 823.1MB (current edge) to 281.8MB.
The following steps are taken:
0) Use go-alpine for a much smaller base image
1) Perform all actions in 1 step to eliminate diff images
2) Remove unused files created after setup
8 years ago
Harshavardhana
5716f1c199
Fix incorrect error strings. ( #2580 )
8 years ago
Harshavardhana
2020afd200
server: http.Server do not add deadlines causes issues. ( #2581 )
...
Adding deadlines is a no go since Golang doesn't back off
the timers if there is an active i/o in progress.
It is meant to be for applications to handle this themselves
and manually progress the deadlines.
Fixes #2561
8 years ago
Bala FA
7431acb2c4
web: add handlers for set/get bucket policy. ( #2486 )
...
Refer #1858
8 years ago
Harshavardhana
2f9975c76c
notifications: GetObjectInfo() later if bucket notifications are set. ( #2575 )
8 years ago
Dee Koder
d9bd73f4e8
docs: Simplified install instructions for home-brew. ( #2571 )
8 years ago
koolhead17
8484d1c0ca
Doc: Modified README.md to add brew package manager install steps. ( #2557 )
8 years ago
Harshavardhana
7270ca4157
pkg/wildcard: Simplify the wildcard logic further. ( #2555 )
8 years ago
Brendan Ashworth
b67c8970c9
bucket-handlers: fix missing return statement ( #2553 )
...
If the location was invalid, it would write an error response but then
continue to attempt to make the bucket. Whether or not it would succeed,
it would attempt to call response.WriteHeaders twice in a row, which
would cause a message to be logged to the server console (bad).
Here is the relevant Go code:
c80e0d374b/src/net/http/server.go (L878-L881)
8 years ago
Mohit Agarwal
418921de89
minor cleanup
...
- Reused contains() from utils.go at a couple of places
- Cleanup in return statements and boolean checks
8 years ago
Harshavardhana
ec4260d260
api: BucketNotification should disallow duplicate notification. ( #2539 )
...
Added checks to look for duplicated notification configs.
Fixes #2472
8 years ago
Harshavardhana
c39d3db7a0
server/tls: allocate tls.Config{} properly. ( #2537 )
...
There is a golang bug which crashes the server, allocate tls.Config properly to avoid
this problem.
```
2016/08/22 20:21:03 http: panic serving 127.0.0.1:40744: runtime error: invalid memory address or nil pointer dereference
goroutine 38 [running]:
net/http.(*conn).serve.func1(0xc820526680)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:1389 +0xc1
panic(0xbefa80, 0xc820010140)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/runtime/panic.go:443 +0x4e9
crypto/tls.(*Conn).serverHandshake(0xc820368300, 0x0, 0x0)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/crypto/tls/handshake_server.go:43 +0x4d6
crypto/tls.(*Conn).Handshake(0xc820368300, 0x0, 0x0)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/crypto/tls/conn.go:1035 +0x169
net/http.(*conn).serve(0xc820526680)
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:1405 +0x382
created by net/http.(*Server).Serve
/home/harsha/.gimme/versions/go1.6.2.linux.amd64/src/net/http/server.go:2137 +0x44e
```
Fixes #2536
8 years ago
Harshavardhana
2da0cfc904
signature: Use the client sent region if region is properly validated. ( #2534 )
...
A properly validated region string from the client should be once
validated properly.
Fixes #2521
8 years ago
Harshavardhana
9dd0e3dc44
config: Initialize notify for fresh configs. ( #2531 )
8 years ago
Dee Koder
4722c94653
typo: Fix capitalization in heading. ( #2529 )
8 years ago
Krishna Srinivas
45c928e2f5
boot: checkPortAvailability() should fail only for EADDRINUSE error and ignore other errors. ( #2527 )
...
fixes #2510
8 years ago
Anis Elleuch
07506358ff
Refactor Heal RPC and add Shutdown RPC ( #2488 )
8 years ago
Harshavardhana
975eb31973
api/bucketPolicy: Use minio-go/pkg/set and fix bucket policy regression. ( #2506 )
...
Current master has a regression 'mc policy <policy-type> alias/bucket/prefix'
does not work anymore, due to the way new minio-go changes do json marshalling.
This led to a regression on server side when a ``prefix`` is provided
policy is rejected as malformed from th server which is not the case with
AWS S3.
This patch uses the new ``minio-go/pkg/set`` package to address the
unmarshalling problems.
Fixes #2503
8 years ago
koolhead17
a3c509fd23
Doc: Modified examples in how-to-run-multiple-minio-server-instances-on-single-machine.md ( #2497 )
8 years ago
GarimaKapoor
63bb78cfc6
Update README.md
8 years ago
Jesse Lucas
f2fd8b0265
Adding test coverage for server-mux.go by creating TestListenAndServeTLS(). ( #2493 )
...
Editing config.go to add lock on customConfigPath to avoid race condition
when setGlobalConfigPath() and getConfigPath() are called concurrently.
8 years ago
Jesse Lucas
a8052889fe
server-mux_test.go updating test to fix race condition with TestListenAndServe ( #2485 )
8 years ago
Harshavardhana
bccf549463
server: Move all the top level files into cmd folder. ( #2490 )
...
This change brings a change which was done for the 'mc'
package to allow for clean repo and have a cleaner
github drop in experience.
8 years ago
Anis Elleuch
73d1a46f3e
Allow asterisk character in key names ( #2487 )
8 years ago
Harshavardhana
95c16f51cb
notification: Handle ARN with empty account and name types. ( #2482 )
...
Fixes #2481
8 years ago
Harshavardhana
810dcbf34b
fs: ListObjects should populate ETag properly if fs.json is available. ( #2480 )
...
Fixes #2470
8 years ago
Harshavardhana
cb77586508
controller: Fix controller cli arguments.
8 years ago
Krishna Srinivas
e2498edb45
contoller: Implement controlled healing and trigger ( #2381 )
...
This patch introduces new command line 'control'
- minio control
TO manage minio server connecting through GoRPC API frontend.
- minio control heal
Is implemented for healing objects.
8 years ago
Jesse Lucas
0b7dfab17a
Refactoring MuxServer Close() method to always wait for conns to close before returning. Adding lock around ServerMux listener setting to protect against data race. Adding additional tests to server-mux_test.go to make sure open connections are closed and for ListenAndServe. ( #2467 )
8 years ago
Krishna Srinivas
674fdc4304
redirect-middleware: Redirect to /minio only if client is a browser and the request is not V4 signed. ( #2469 )
...
fixes #2356
8 years ago
karthic rao
10feb1af3f
tests: object handlers: Unit tests for Get and Copy Object handlers ( #2451 )
8 years ago
GarimaKapoor
d2b924cca8
Added Goreportcard badge.
8 years ago
Brendan Ashworth
13390d0c95
tests: add tests for signature-v4.go ( #2458 )
...
This adds tests for the functions `doesPresignedSignatureMatch` and
`doesPolicySignatureMatch`.
8 years ago
Harshavardhana
0a3d43273f
vendor: sha256 32bit updated. ( #2459 )
8 years ago
Harshavardhana
4dec50ba51
build: Add platform specific fixes.
8 years ago
Krishna Srinivas
f2bffe6086
fs/delete-object: fs.json filepath was incorrect. ( #2448 )
8 years ago
Krishna Srinivas
8e2f64aea4
fs/multipart: save metadata(fs.json) for multipart uploads. ( #2450 )
8 years ago
Harshavardhana
c054e633fd
utils: Shutdown channel should be bufferred.
8 years ago