From fd1f09a66c9b45d4b71cef45af7cd1126d9bee42 Mon Sep 17 00:00:00 2001 From: Anis Elleuch Date: Fri, 25 Nov 2016 19:39:00 +0100 Subject: [PATCH] log: Enable loggers just after configuration load (#3348) It would make sense to enable logger just after config initialisation. That way, errorIf() and fatalIf() will be usable and can catch error like invalid access and key errors. --- cmd/main.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/cmd/main.go b/cmd/main.go index d76e084f3..fb7017c33 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -167,11 +167,16 @@ func Main() { // Initialize config. configCreated, err := initConfig() - fatalIf(err, "Unable to initialize minio config.") + if err != nil { + console.Fatalf("Unable to initialize minio config. Err: %s.\n", err) + } if configCreated { console.Println("Created minio configuration file at " + mustGetConfigPath()) } + // Enable all loggers by now so we can use errorIf() and fatalIf() + enableLoggers() + // Fetch access keys from environment variables and update the config. accessKey := os.Getenv("MINIO_ACCESS_KEY") secretKey := os.Getenv("MINIO_SECRET_KEY") @@ -189,9 +194,6 @@ func Main() { fatalIf(errInvalidArgument, "Invalid secret key. Accept only a string containing from 8 to 40 characters.") } - // Enable all loggers by now. - enableLoggers() - // Init the error tracing module. initError()