From eff4127efd63a835d98b15a7b0e939d8ace756de Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Mon, 27 Apr 2020 09:22:05 -0700 Subject: [PATCH] Revert "Write files in O_SYNC for fs backend to protect against machine crashes (#9434)" This reverts commit 4843affd0eab28e14e89de3f4c9a040d3b2659ca. --- cmd/fs-v1-helpers.go | 2 +- pkg/ioutil/append-file_nix.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/fs-v1-helpers.go b/cmd/fs-v1-helpers.go index 79e27418e..a275c08b6 100644 --- a/cmd/fs-v1-helpers.go +++ b/cmd/fs-v1-helpers.go @@ -321,7 +321,7 @@ func fsCreateFile(ctx context.Context, filePath string, reader io.Reader, buf [] return 0, err } - writer, err := lock.Open(filePath, os.O_CREATE|os.O_WRONLY|os.O_SYNC, 0666) + writer, err := lock.Open(filePath, os.O_CREATE|os.O_WRONLY, 0666) if err != nil { return 0, osErrToFSFileErr(err) } diff --git a/pkg/ioutil/append-file_nix.go b/pkg/ioutil/append-file_nix.go index a5b937fc6..f82367a9f 100644 --- a/pkg/ioutil/append-file_nix.go +++ b/pkg/ioutil/append-file_nix.go @@ -25,7 +25,7 @@ import ( // AppendFile - appends the file "src" to the file "dst" func AppendFile(dst string, src string) error { - appendFile, err := os.OpenFile(dst, os.O_WRONLY|os.O_APPEND|os.O_CREATE|os.O_SYNC, 0666) + appendFile, err := os.OpenFile(dst, os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0666) if err != nil { return err }