From db1edfe4872f295a141a34db910876e84371e49f Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Wed, 11 Oct 2017 10:17:37 -0700 Subject: [PATCH] Fix data race bug in the testcase TestHTTPListenerAcceptParallel (#5043) --- pkg/http/listener_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/http/listener_test.go b/pkg/http/listener_test.go index fdf74e8ca..cc1403507 100644 --- a/pkg/http/listener_test.go +++ b/pkg/http/listener_test.go @@ -734,7 +734,6 @@ func TestHTTPListenerAcceptParallel(t *testing.T) { } handleConnection := func(i int, wg *sync.WaitGroup, serverConn net.Conn, request, reply string) { - wg.Add(1) defer wg.Done() received, err := bufio.NewReader(serverConn).ReadString('\n') @@ -778,12 +777,14 @@ func TestHTTPListenerAcceptParallel(t *testing.T) { if err != nil { t.Fatalf("Test %d: accept: expected = , got = %v", i+1, err) } + wg.Add(1) go handleConnection(i, &wg, serverConn, "GET /2 HTTP/1.0\n", testCase.reply) serverConn, err = listener.Accept() if err != nil { t.Fatalf("Test %d: accept: expected = , got = %v", i+1, err) } + wg.Add(1) go handleConnection(i, &wg, serverConn, "GET /1 HTTP/1.0\n", testCase.reply) wg.Wait()