From d31f256020de8c175bc7d5ea9b05a438b16896e0 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Fri, 2 Dec 2016 17:42:37 -0800 Subject: [PATCH] Fail on lint errors during CI build. --- .travis.yml | 1 + Makefile | 4 ++-- cmd/postpolicyform_test.go | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index a7304df17..814e766c0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,6 +13,7 @@ env: - ARCH=i686 script: +- make - make test GOFLAGS="-race" - make coverage diff --git a/Makefile b/Makefile index 7c19fa231..1f2af664d 100644 --- a/Makefile +++ b/Makefile @@ -83,8 +83,8 @@ fmt: lint: @echo "Running $@:" - @GO15VENDOREXPERIMENT=1 ${GOPATH}/bin/golint github.com/minio/minio/cmd... - @GO15VENDOREXPERIMENT=1 ${GOPATH}/bin/golint github.com/minio/minio/pkg... + @GO15VENDOREXPERIMENT=1 ${GOPATH}/bin/golint -set_exit_status github.com/minio/minio/cmd... + @GO15VENDOREXPERIMENT=1 ${GOPATH}/bin/golint -set_exit_status github.com/minio/minio/pkg... ineffassign: @echo "Running $@:" diff --git a/cmd/postpolicyform_test.go b/cmd/postpolicyform_test.go index 4294d5a0c..0281da871 100644 --- a/cmd/postpolicyform_test.go +++ b/cmd/postpolicyform_test.go @@ -58,7 +58,7 @@ func TestPostPolicyForm(t *testing.T) { for i, tt := range testCases { formValues := make(map[string]string) formValues["Bucket"] = tt.Bucket - formValues["Acl"] = tt.Acl + formValues["Acl"] = tt.ACL formValues["Key"] = tt.Key formValues["X-Amz-Date"] = tt.XAmzDate formValues["X-Amz-Meta-Uuid"] = tt.XAmzMetaUUID