From c310cbbe89df73bed641be0960a8153af6491af8 Mon Sep 17 00:00:00 2001 From: Mike Scarlett Date: Fri, 6 Jul 2018 17:07:11 -0700 Subject: [PATCH] Update comments regarding GCS component count (#6131) --- cmd/gateway/gcs/gateway-gcs.go | 8 ++------ docs/gateway/gcs.md | 1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/gateway/gcs/gateway-gcs.go b/cmd/gateway/gcs/gateway-gcs.go index a65aba30d..fa06054fe 100644 --- a/cmd/gateway/gcs/gateway-gcs.go +++ b/cmd/gateway/gcs/gateway-gcs.go @@ -1015,12 +1015,8 @@ func (l *gcsGateway) AbortMultipartUpload(ctx context.Context, bucket string, ke // CompleteMultipartUpload completes ongoing multipart upload and finalizes object // Note that there is a limit (currently 32) to the number of components that can -// be composed in a single operation. There is a limit (currently 1024) to the total -// number of components for a given composite object. This means you can append to -// each object at most 1023 times. There is a per-project rate limit (currently 200) -// to the number of components you can compose per second. This rate counts both the -// components being appended to a composite object as well as the components being -// copied when the composite object of which they are a part is copied. +// be composed in a single operation. There is a per-project rate limit (currently 200) +// to the number of source objects you can compose per second. func (l *gcsGateway) CompleteMultipartUpload(ctx context.Context, bucket string, key string, uploadID string, uploadedParts []minio.CompletePart) (minio.ObjectInfo, error) { meta := gcsMultipartMetaName(uploadID) object := l.client.Bucket(bucket).Object(meta) diff --git a/docs/gateway/gcs.md b/docs/gateway/gcs.md index fcc337d5d..f54c00b0c 100644 --- a/docs/gateway/gcs.md +++ b/docs/gateway/gcs.md @@ -55,7 +55,6 @@ mc ls mygcs ### Known limitations Gateway inherits the following GCS limitations: -- Maximum number of multipart parts per upload is 1024. - Only read-only or write-only bucket policy supported at bucket level, all other variations will return API Notimplemented error. - _List Multipart Uploads_ and _List Object parts_ always returns empty list. i.e Client will need to remember all the parts that it has uploaded and use it for _Complete Multipart Upload_