From c06b9abc1567945f349f152add1966a68cdb3e72 Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Sat, 7 May 2016 04:34:46 +0530 Subject: [PATCH] bucket-handlers: do not unescape marker as gorilla layer would have already done it. (#1495) (#1510) --- bucket-handlers.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/bucket-handlers.go b/bucket-handlers.go index 054cadcf2..ce1feb154 100644 --- a/bucket-handlers.go +++ b/bucket-handlers.go @@ -171,14 +171,6 @@ func (api objectAPIHandlers) ListMultipartUploadsHandler(w http.ResponseWriter, return } if keyMarker != "" { - // Unescape keyMarker string - keyMarkerUnescaped, err := url.QueryUnescape(keyMarker) - if err != nil { - // Return 'NoSuchKey' to indicate invalid marker key. - writeErrorResponse(w, r, ErrNoSuchKey, r.URL.Path) - return - } - keyMarker = keyMarkerUnescaped // Marker not common with prefix is not implemented. if !strings.HasPrefix(keyMarker, prefix) { writeErrorResponse(w, r, ErrNotImplemented, r.URL.Path) @@ -242,14 +234,6 @@ func (api objectAPIHandlers) ListObjectsHandler(w http.ResponseWriter, r *http.R } // If marker is set unescape. if marker != "" { - // Try to unescape marker. - markerUnescaped, err := url.QueryUnescape(marker) - if err != nil { - // Return 'NoSuchKey' to indicate invalid marker key. - writeErrorResponse(w, r, ErrNoSuchKey, r.URL.Path) - return - } - marker = markerUnescaped // Marker not common with prefix is not implemented. if !strings.HasPrefix(marker, prefix) { writeErrorResponse(w, r, ErrNotImplemented, r.URL.Path)