From ba0c7544ea54c97c4c393beb1d0750152605684c Mon Sep 17 00:00:00 2001 From: Nitish Tiwari Date: Fri, 9 Mar 2018 15:21:41 +0530 Subject: [PATCH] Cleanup orchestration documents (#5623) - Remove hostPort from Kubernetes deployment example docs. Initially hostPort was added to ensure Minio pods are allocated to separate machines, but as per latest Kubernetes documents this is not recommended approach (ref: https://kubernetes.io/docs/concepts/ configuration/overview/#services). To define pod allocations, Affinity and Anti-Affinity concepts are the recommended approach. (ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node) - Add Minio release tag to Docker-Compose example file. --- docs/orchestration/docker-compose/docker-compose.yaml | 8 ++++---- docs/orchestration/kubernetes-yaml/README.md | 3 --- .../kubernetes-yaml/minio-distributed-statefulset.yaml | 1 - .../kubernetes-yaml/minio-gcs-gateway-deployment.yaml | 1 - .../kubernetes-yaml/minio-standalone-deployment.yaml | 1 - docs/zh_CN/orchestration/kubernetes-yaml/README.md | 3 --- 6 files changed, 4 insertions(+), 13 deletions(-) diff --git a/docs/orchestration/docker-compose/docker-compose.yaml b/docs/orchestration/docker-compose/docker-compose.yaml index 941b53ab6..5bc69521f 100644 --- a/docs/orchestration/docker-compose/docker-compose.yaml +++ b/docs/orchestration/docker-compose/docker-compose.yaml @@ -5,7 +5,7 @@ version: '2' # 9001 through 9004. services: minio1: - image: minio/minio + image: minio/minio:RELEASE.2018-02-09T22-40-05Z volumes: - data1:/data ports: @@ -15,7 +15,7 @@ services: MINIO_SECRET_KEY: minio123 command: server http://minio1/data http://minio2/data http://minio3/data http://minio4/data minio2: - image: minio/minio + image: minio/minio:RELEASE.2018-02-09T22-40-05Z volumes: - data2:/data ports: @@ -25,7 +25,7 @@ services: MINIO_SECRET_KEY: minio123 command: server http://minio1/data http://minio2/data http://minio3/data http://minio4/data minio3: - image: minio/minio + image: minio/minio:RELEASE.2018-02-09T22-40-05Z volumes: - data3:/data ports: @@ -35,7 +35,7 @@ services: MINIO_SECRET_KEY: minio123 command: server http://minio1/data http://minio2/data http://minio3/data http://minio4/data minio4: - image: minio/minio + image: minio/minio:RELEASE.2018-02-09T22-40-05Z volumes: - data4:/data ports: diff --git a/docs/orchestration/kubernetes-yaml/README.md b/docs/orchestration/kubernetes-yaml/README.md index 805d51c16..2a33003db 100644 --- a/docs/orchestration/kubernetes-yaml/README.md +++ b/docs/orchestration/kubernetes-yaml/README.md @@ -135,7 +135,6 @@ spec: value: "minio123" ports: - containerPort: 9000 - hostPort: 9000 ``` Create the Deployment @@ -294,7 +293,6 @@ spec: - http://minio-3.minio.default.svc.cluster.local/data ports: - containerPort: 9000 - hostPort: 9000 # These volume mounts are persistent. Each pod in the PetSet # gets a volume mounted based on this field. volumeMounts: @@ -475,7 +473,6 @@ spec: value: "/etc/credentials/application_default_credentials.json" ports: - containerPort: 9000 - hostPort: 9000 # Mount the volume into the pod volumeMounts: - name: gcs-credentials diff --git a/docs/orchestration/kubernetes-yaml/minio-distributed-statefulset.yaml b/docs/orchestration/kubernetes-yaml/minio-distributed-statefulset.yaml index 0ad88bb74..1114915da 100644 --- a/docs/orchestration/kubernetes-yaml/minio-distributed-statefulset.yaml +++ b/docs/orchestration/kubernetes-yaml/minio-distributed-statefulset.yaml @@ -30,7 +30,6 @@ spec: - http://minio-3.minio.default.svc.cluster.local/data ports: - containerPort: 9000 - hostPort: 9000 # These volume mounts are persistent. Each pod in the PetSet # gets a volume mounted based on this field. volumeMounts: diff --git a/docs/orchestration/kubernetes-yaml/minio-gcs-gateway-deployment.yaml b/docs/orchestration/kubernetes-yaml/minio-gcs-gateway-deployment.yaml index 17ff737fb..c194e0e3c 100644 --- a/docs/orchestration/kubernetes-yaml/minio-gcs-gateway-deployment.yaml +++ b/docs/orchestration/kubernetes-yaml/minio-gcs-gateway-deployment.yaml @@ -37,7 +37,6 @@ spec: value: "/etc/credentials/application_default_credentials.json" ports: - containerPort: 9000 - hostPort: 9000 # Mount the volume into the pod volumeMounts: - name: gcs-credentials diff --git a/docs/orchestration/kubernetes-yaml/minio-standalone-deployment.yaml b/docs/orchestration/kubernetes-yaml/minio-standalone-deployment.yaml index c4a91b2fe..cbf57994a 100644 --- a/docs/orchestration/kubernetes-yaml/minio-standalone-deployment.yaml +++ b/docs/orchestration/kubernetes-yaml/minio-standalone-deployment.yaml @@ -41,4 +41,3 @@ spec: value: "minio123" ports: - containerPort: 9000 - hostPort: 9000 diff --git a/docs/zh_CN/orchestration/kubernetes-yaml/README.md b/docs/zh_CN/orchestration/kubernetes-yaml/README.md index 5b345908c..aed973cc4 100644 --- a/docs/zh_CN/orchestration/kubernetes-yaml/README.md +++ b/docs/zh_CN/orchestration/kubernetes-yaml/README.md @@ -127,7 +127,6 @@ spec: value: "minio123" ports: - containerPort: 9000 - hostPort: 9000 # Mount the volume into the pod volumeMounts: - name: data # must match the volume name, above @@ -287,7 +286,6 @@ spec: - http://minio-3.minio.default.svc.cluster.local/data ports: - containerPort: 9000 - hostPort: 9000 # These volume mounts are persistent. Each pod in the PetSet # gets a volume mounted based on this field. volumeMounts: @@ -470,7 +468,6 @@ spec: value: "/etc/credentials/application_default_credentials.json" ports: - containerPort: 9000 - hostPort: 9000 # Mount the volume into the pod volumeMounts: - name: gcs-credentials