SetConfigHandler should avoid setting an invalid notification config (#6679)

Fixes #6642 Fixes #6641
6 years ago · acf46cc3b5
parent 06ef8248c3
commit acf46cc3b5
1 changed files with 5 additions and 0 deletions
--- a/cmd/admin-handlers.go
+++ b/cmd/admin-handlers.go
@ -1114,6 +1114,11 @@ func (a adminAPIHandlers) SetConfigHandler(w http.ResponseWriter, r *http.Reques
 		return
 	}

+	if err = config.TestNotificationTargets(); err != nil {
+		writeCustomErrorResponseJSON(w, ErrAdminConfigBadJSON, err.Error(), r.URL)
+		return
+	}
+
 	if err = saveServerConfig(ctx, objectAPI, &config); err != nil {
 		writeErrorResponseJSON(w, toAdminAPIErrCode(err), r.URL)
 		return