From 9ed7fb49162e59ffd74c5729189cb61599c8c18f Mon Sep 17 00:00:00 2001 From: kannappanr <30541348+kannappanr@users.noreply.github.com> Date: Wed, 31 Oct 2018 14:09:26 -0700 Subject: [PATCH] Do not call multiple response.WriteHeader calls (#6733) Execute method in s3Select package makes a response.WriteHeader call. Not calling it again in SelectObjectContentHandler function in case of error in s3Select.Execute call. --- cmd/object-handlers.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/cmd/object-handlers.go b/cmd/object-handlers.go index e69dbdc71..5551d5476 100644 --- a/cmd/object-handlers.go +++ b/cmd/object-handlers.go @@ -269,10 +269,7 @@ func (api objectAPIHandlers) SelectObjectContentHandler(w http.ResponseWriter, r } // Executes the query on data-set - if err = s3select.Execute(w, s3s); err != nil { - writeErrorResponse(w, toAPIErrorCode(err), r.URL) - return - } + s3select.Execute(w, s3s) for k, v := range objInfo.UserDefined { logger.GetReqInfo(ctx).SetTags(k, v)