From 99a42989386f68bd467b970a5fccd163500056fb Mon Sep 17 00:00:00 2001 From: kannappanr <30541348+kannappanr@users.noreply.github.com> Date: Wed, 21 Aug 2019 09:10:52 +0530 Subject: [PATCH] Use a non-strict invalid bucket name check in Get and Delete object (#8073) --- cmd/object-api-getobjectinfo_test.go | 1 - cmd/object-api-input-checks.go | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/object-api-getobjectinfo_test.go b/cmd/object-api-getobjectinfo_test.go index e2b8d151f..4c87fcaef 100644 --- a/cmd/object-api-getobjectinfo_test.go +++ b/cmd/object-api-getobjectinfo_test.go @@ -64,7 +64,6 @@ func testGetObjectInfo(obj ObjectLayer, instanceType string, t TestErrHandler) { }{ // Test cases with invalid bucket names ( Test number 1-4 ). {".test", "", ObjectInfo{}, BucketNameInvalid{Bucket: ".test"}, false}, - {"Test", "", ObjectInfo{}, BucketNameInvalid{Bucket: "Test"}, false}, {"---", "", ObjectInfo{}, BucketNameInvalid{Bucket: "---"}, false}, {"ad", "", ObjectInfo{}, BucketNameInvalid{Bucket: "ad"}, false}, // Test cases with valid but non-existing bucket names (Test number 5-6). diff --git a/cmd/object-api-input-checks.go b/cmd/object-api-input-checks.go index da5294521..3e02fc7f3 100644 --- a/cmd/object-api-input-checks.go +++ b/cmd/object-api-input-checks.go @@ -19,6 +19,7 @@ package cmd import ( "context" + "github.com/minio/minio-go/v6/pkg/s3utils" "github.com/minio/minio/cmd/logger" "github.com/skyrings/skyring-common/tools/uuid" ) @@ -36,7 +37,7 @@ func checkDelObjArgs(ctx context.Context, bucket, object string) error { // Checks bucket and object name validity, returns nil if both are valid. func checkBucketAndObjectNames(ctx context.Context, bucket, object string) error { // Verify if bucket is valid. - if !IsValidBucketName(bucket) { + if !isMinioMetaBucketName(bucket) && s3utils.CheckValidBucketName(bucket) != nil { logger.LogIf(ctx, BucketNameInvalid{Bucket: bucket}) return BucketNameInvalid{Bucket: bucket} }