From 98ca770f81442142e959104804bcee30facce38d Mon Sep 17 00:00:00 2001
From: Harshavardhana <harsha@minio.io>
Date: Wed, 19 Aug 2020 20:07:37 -0700
Subject: [PATCH] mint fixes for go1.14 (#10294)

add go.mod to ensure that mint can be
built with go1.14.x
---
 mint/build/aws-sdk-go/install.sh                      | 2 +-
 mint/build/healthcheck/install.sh                     | 2 +-
 mint/build/minio-go/install.sh                        | 5 ++---
 mint/build/minio-py/install.sh                        | 4 ++--
 mint/build/security/install.sh                        | 2 +-
 mint/mint.sh                                          | 7 +++++--
 mint/run/core/aws-sdk-go/go.mod                       | 3 +++
 mint/run/core/aws-sdk-go/{quick-tests.go => main.go}  | 0
 mint/run/core/healthcheck/go.mod                      | 3 +++
 mint/run/core/healthcheck/{healthcheck.go => main.go} | 0
 mint/run/core/minio-go/go.mod                         | 3 +++
 mint/run/core/s3cmd/test.sh                           | 2 +-
 mint/run/core/security/go.mod                         | 3 +++
 mint/run/core/security/{tls-tests.go => main.go}      | 0
 14 files changed, 25 insertions(+), 11 deletions(-)
 create mode 100644 mint/run/core/aws-sdk-go/go.mod
 rename mint/run/core/aws-sdk-go/{quick-tests.go => main.go} (100%)
 create mode 100644 mint/run/core/healthcheck/go.mod
 rename mint/run/core/healthcheck/{healthcheck.go => main.go} (100%)
 create mode 100644 mint/run/core/minio-go/go.mod
 create mode 100644 mint/run/core/security/go.mod
 rename mint/run/core/security/{tls-tests.go => main.go} (100%)

diff --git a/mint/build/aws-sdk-go/install.sh b/mint/build/aws-sdk-go/install.sh
index d73162840..a41844841 100755
--- a/mint/build/aws-sdk-go/install.sh
+++ b/mint/build/aws-sdk-go/install.sh
@@ -16,4 +16,4 @@
 #
 
 test_run_dir="$MINT_RUN_CORE_DIR/aws-sdk-go"
-GO111MODULE=on go build -o "$test_run_dir/aws-sdk-go" "$test_run_dir/quick-tests.go"
+(cd "$test_run_dir" && GO111MODULE=on CGO_ENABLED=0 go build)
diff --git a/mint/build/healthcheck/install.sh b/mint/build/healthcheck/install.sh
index 71ffe4823..b3275b23e 100755
--- a/mint/build/healthcheck/install.sh
+++ b/mint/build/healthcheck/install.sh
@@ -16,4 +16,4 @@
 #
 
 test_run_dir="$MINT_RUN_CORE_DIR/healthcheck"
-GO111MODULE=on go build -o "$test_run_dir/healthcheck" "$test_run_dir/healthcheck.go"
+(cd "$test_run_dir" && GO111MODULE=on CGO_ENABLED=0 go build)
diff --git a/mint/build/minio-go/install.sh b/mint/build/minio-go/install.sh
index 5e3005199..b907774ed 100755
--- a/mint/build/minio-go/install.sh
+++ b/mint/build/minio-go/install.sh
@@ -22,6 +22,5 @@ if [ -z "$MINIO_GO_VERSION" ]; then
 fi
 
 test_run_dir="$MINT_RUN_CORE_DIR/minio-go"
-(git clone https://github.com/minio/minio-go && cd minio-go && git checkout --quiet "tags/$MINIO_GO_VERSION")
-GO111MODULE=on CGO_ENABLED=0 go build -o "$test_run_dir/minio-go" "minio-go/functional_tests.go"
-rm -rf minio-go
+curl -sL -o "${test_run_dir}/main.go" "https://raw.githubusercontent.com/minio/minio-go/${MINIO_GO_VERSION}/functional_tests.go"
+(cd "$test_run_dir" && GO111MODULE=on CGO_ENABLED=0 go build -o minio-go main.go)
diff --git a/mint/build/minio-py/install.sh b/mint/build/minio-py/install.sh
index 39bd990e7..ca877cc01 100755
--- a/mint/build/minio-py/install.sh
+++ b/mint/build/minio-py/install.sh
@@ -23,5 +23,5 @@ fi
 
 test_run_dir="$MINT_RUN_CORE_DIR/minio-py"
 pip3 install --user faker
-pip3 install minio=="$MINIO_PY_VERSION"
-$WGET --output-document="$test_run_dir/tests.py" "https://raw.githubusercontent.com/minio/minio-py/${MINIO_PY_VERSION}/tests/functional/tests.py"
+pip3 install git+http://github.com/minio/minio-py
+$WGET --output-document="$test_run_dir/tests.py" "https://raw.githubusercontent.com/minio/minio-py/master/tests/functional/tests.py"
diff --git a/mint/build/security/install.sh b/mint/build/security/install.sh
index a517bfb18..8f7f38d8a 100755
--- a/mint/build/security/install.sh
+++ b/mint/build/security/install.sh
@@ -16,4 +16,4 @@
 #
 
 test_run_dir="$MINT_RUN_CORE_DIR/security"
-GO111MODULE=on go build -o "$test_run_dir/tls-tests" "$test_run_dir/tls-tests.go"
+(cd "$test_run_dir" && GO111MODULE=on CGO_ENABLED=0 go build -o tls-tests)
diff --git a/mint/mint.sh b/mint/mint.sh
index 56d44b1cf..e2803bbb3 100755
--- a/mint/mint.sh
+++ b/mint/mint.sh
@@ -97,7 +97,7 @@ function run_test()
         fi
         ## Show error.log when status is empty or not "FAIL".
         ## This may happen when test run failed without providing logs.
-        if [ "$jq_rv" -ne 0 ] || [ -z "$status" ] || ([ "$status" != "FAIL" ] && [ "$status" != "fail" ]); then
+        if [ "$jq_rv" -ne 0 ] || [ -z "$status" ] || { [ "$status" != "FAIL" ] && [ "$status" != "fail" ]; }; then
             cat "$BASE_LOG_DIR/$sdk_name/$ERROR_FILE"
         else
             jq . <<<"$entry"
@@ -157,10 +157,13 @@ function main()
     sdks=( "$@" )
 
     if [ "$#" -eq 0 ]; then
-        sdks=( $(ls "$TESTS_DIR") )
+        cd "$TESTS_DIR" || exit
+        sdks=(*)
+        cd .. || exit
     fi
 
     for sdk in "${sdks[@]}"; do
+        sdk=$(basename "$sdk")
         run_list=( "${run_list[@]}" "$TESTS_DIR/$sdk" )
     done
 
diff --git a/mint/run/core/aws-sdk-go/go.mod b/mint/run/core/aws-sdk-go/go.mod
new file mode 100644
index 000000000..0d28c584a
--- /dev/null
+++ b/mint/run/core/aws-sdk-go/go.mod
@@ -0,0 +1,3 @@
+module mint.minio.io/aws-sdk-go
+
+go 1.14
diff --git a/mint/run/core/aws-sdk-go/quick-tests.go b/mint/run/core/aws-sdk-go/main.go
similarity index 100%
rename from mint/run/core/aws-sdk-go/quick-tests.go
rename to mint/run/core/aws-sdk-go/main.go
diff --git a/mint/run/core/healthcheck/go.mod b/mint/run/core/healthcheck/go.mod
new file mode 100644
index 000000000..2145cd259
--- /dev/null
+++ b/mint/run/core/healthcheck/go.mod
@@ -0,0 +1,3 @@
+module mint.minio.io/healthcheck
+
+go 1.14
diff --git a/mint/run/core/healthcheck/healthcheck.go b/mint/run/core/healthcheck/main.go
similarity index 100%
rename from mint/run/core/healthcheck/healthcheck.go
rename to mint/run/core/healthcheck/main.go
diff --git a/mint/run/core/minio-go/go.mod b/mint/run/core/minio-go/go.mod
new file mode 100644
index 000000000..0ce4ece6b
--- /dev/null
+++ b/mint/run/core/minio-go/go.mod
@@ -0,0 +1,3 @@
+module mint.minio.io/minio-go
+
+go 1.14
diff --git a/mint/run/core/s3cmd/test.sh b/mint/run/core/s3cmd/test.sh
index a33d50562..2c52a79ff 100755
--- a/mint/run/core/s3cmd/test.sh
+++ b/mint/run/core/s3cmd/test.sh
@@ -57,7 +57,7 @@ declare FILE_1_MB_MD5SUM
 declare FILE_65_MB_MD5SUM
 
 BUCKET_NAME="s3cmd-test-bucket-$RANDOM"
-S3CMD=$(which s3cmd)
+S3CMD=$(command -v s3cmd)
 declare -a S3CMD_CMD
 
 function get_md5sum()
diff --git a/mint/run/core/security/go.mod b/mint/run/core/security/go.mod
new file mode 100644
index 000000000..b24d48923
--- /dev/null
+++ b/mint/run/core/security/go.mod
@@ -0,0 +1,3 @@
+module mint.minio.io/security
+
+go 1.14
diff --git a/mint/run/core/security/tls-tests.go b/mint/run/core/security/main.go
similarity index 100%
rename from mint/run/core/security/tls-tests.go
rename to mint/run/core/security/main.go