diff --git a/cmd/endpoint.go b/cmd/endpoint.go index 6e04b1e98..dabcdc150 100644 --- a/cmd/endpoint.go +++ b/cmd/endpoint.go @@ -205,7 +205,6 @@ func (endpoints EndpointList) GetString(i int) string { func localEndpointsMemUsage(endpoints EndpointList) ServerMemUsageInfo { var memUsages []mem.Usage var historicUsages []mem.Usage - var addr string scratchSpace := map[string]bool{} for _, endpoint := range endpoints { // Only proceed for local endpoints @@ -213,16 +212,13 @@ func localEndpointsMemUsage(endpoints EndpointList) ServerMemUsageInfo { if _, ok := scratchSpace[endpoint.Host]; ok { continue } - addr = GetLocalPeer(endpoints) - memUsage := mem.GetUsage() - memUsages = append(memUsages, memUsage) - historicUsage := mem.GetHistoricUsage() - historicUsages = append(historicUsages, historicUsage) + memUsages = append(memUsages, mem.GetUsage()) + historicUsages = append(historicUsages, mem.GetHistoricUsage()) scratchSpace[endpoint.Host] = true } } return ServerMemUsageInfo{ - Addr: addr, + Addr: GetLocalPeer(endpoints), Usage: memUsages, HistoricUsage: historicUsages, } @@ -233,7 +229,6 @@ func localEndpointsMemUsage(endpoints EndpointList) ServerMemUsageInfo { func localEndpointsCPULoad(endpoints EndpointList) ServerCPULoadInfo { var cpuLoads []cpu.Load var historicLoads []cpu.Load - var addr string scratchSpace := map[string]bool{} for _, endpoint := range endpoints { // Only proceed for local endpoints @@ -241,16 +236,13 @@ func localEndpointsCPULoad(endpoints EndpointList) ServerCPULoadInfo { if _, ok := scratchSpace[endpoint.Host]; ok { continue } - addr = GetLocalPeer(endpoints) - cpuLoad := cpu.GetLoad() - cpuLoads = append(cpuLoads, cpuLoad) - historicLoad := cpu.GetHistoricLoad() - historicLoads = append(historicLoads, historicLoad) + cpuLoads = append(cpuLoads, cpu.GetLoad()) + historicLoads = append(historicLoads, cpu.GetHistoricLoad()) scratchSpace[endpoint.Host] = true } } return ServerCPULoadInfo{ - Addr: addr, + Addr: GetLocalPeer(endpoints), Load: cpuLoads, HistoricLoad: historicLoads, } @@ -260,26 +252,22 @@ func localEndpointsCPULoad(endpoints EndpointList) ServerCPULoadInfo { // local endpoints from given list of endpoints func localEndpointsDrivePerf(endpoints EndpointList) ServerDrivesPerfInfo { var dps []disk.Performance - var addr string for _, endpoint := range endpoints { // Only proceed for local endpoints if endpoint.IsLocal { - addr = GetLocalPeer(endpoints) if _, err := os.Stat(endpoint.Path); err != nil { // Since this drive is not available, add relevant details and proceed dps = append(dps, disk.Performance{Path: endpoint.Path, Error: err.Error()}) continue } - tempObj := mustGetUUID() - fsPath := pathJoin(endpoint.Path, minioMetaTmpBucket, tempObj) - dp := disk.GetPerformance(fsPath) + dp := disk.GetPerformance(pathJoin(endpoint.Path, minioMetaTmpBucket, mustGetUUID())) dp.Path = endpoint.Path dps = append(dps, dp) } } return ServerDrivesPerfInfo{ - Addr: addr, + Addr: GetLocalPeer(endpoints), Perf: dps, } }