From 7cc77eba4576afff38356e6c97b848aefe45d61f Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Thu, 1 Sep 2016 00:12:57 +0530 Subject: [PATCH] XL/Healing: errDiskNotFound is the only pardonable error in xlShouldHeal. (#2586) This is so that we try to heal a file for all the "bad" cases except when the disk is down. --- cmd/xl-v1-healing.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/xl-v1-healing.go b/cmd/xl-v1-healing.go index d7ba14990..73b0768c1 100644 --- a/cmd/xl-v1-healing.go +++ b/cmd/xl-v1-healing.go @@ -135,10 +135,10 @@ func xlShouldHeal(partsMetadata []xlMetaV1, errs []error) bool { modTime := commonTime(listObjectModtimes(partsMetadata, errs)) for index := range partsMetadata { if errs[index] == errDiskNotFound { - return true + continue } if errs[index] != nil { - continue + return true } if modTime != partsMetadata[index].Stat.ModTime { return true