From 5549a4456699ab2472a8cdd13155449fe728b0f6 Mon Sep 17 00:00:00 2001 From: Andreas Auernhammer Date: Sat, 1 Dec 2018 14:28:49 +0100 Subject: [PATCH] rename vault namespace env variable to be more idiomatic (#6905) This commit renames the env variable for vault namespaces such that it begins with `MINIO_SSE_`. This is the prefix for all Minio SSE related env. variables (like KMS). --- cmd/crypto/vault.go | 2 +- docs/kms/README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/crypto/vault.go b/cmd/crypto/vault.go index 150064648..a5c796f59 100644 --- a/cmd/crypto/vault.go +++ b/cmd/crypto/vault.go @@ -193,7 +193,7 @@ func NewVault(kmsConf KMSConfig) (KMS, error) { return nil, err } - if ns, ok := os.LookupEnv("VAULT_NAMESPACE"); ok { + if ns, ok := os.LookupEnv("MINIO_SSE_VAULT_NAMESPACE"); ok { c.SetNamespace(ns) } diff --git a/docs/kms/README.md b/docs/kms/README.md index 51a0619d3..f5a09114d 100644 --- a/docs/kms/README.md +++ b/docs/kms/README.md @@ -69,9 +69,9 @@ Optionally set `MINIO_SSE_VAULT_CAPATH` as the path to a directory of PEM-encode export MINIO_SSE_VAULT_CAPATH=/home/user/custom-pems ``` -Optionally set `VAULT_NAMESPACE` if AppRole and Transit Secrets engine have been scoped to Vault Namespace +Optionally set `MINIO_SSE_VAULT_NAMESPACE` if AppRole and Transit Secrets engine have been scoped to Vault Namespace ``` -export VAULT_NAMESPACE=ns1 +export MINIO_SSE_VAULT_NAMESPACE=ns1 ``` ### 4. Test your setup