diff --git a/cmd/gateway-main.go b/cmd/gateway-main.go index 1bc1e6d5f..925a8f599 100644 --- a/cmd/gateway-main.go +++ b/cmd/gateway-main.go @@ -18,7 +18,6 @@ package cmd import ( "context" - "errors" "fmt" "net/url" "os" @@ -151,10 +150,7 @@ func StartGateway(ctx *cli.Context, gw Gateway) { // Validate if we have access, secret set through environment. if !globalIsEnvCreds { - reqInfo := (&logger.ReqInfo{}).AppendTags("gatewayName", gatewayName) - contxt := logger.SetReqInfo(context.Background(), reqInfo) - logger.LogIf(contxt, errors.New("Access and Secret keys should be set through ENVs for backend")) - cli.ShowCommandHelpAndExit(ctx, gatewayName, 1) + logger.Fatal(uiErrEnvCredentialsMissing(nil), "Unable to start gateway") } // Create certs path. diff --git a/cmd/gateway/nas/gateway-nas.go b/cmd/gateway/nas/gateway-nas.go index f368bffed..15131201a 100644 --- a/cmd/gateway/nas/gateway-nas.go +++ b/cmd/gateway/nas/gateway-nas.go @@ -63,7 +63,7 @@ EXAMPLES: $ export MINIO_ACCESS_KEY=accesskey $ export MINIO_SECRET_KEY=secretkey $ {{.HelpName}} /shared/nasvol - + 2. Start minio gateway server for NAS with edge caching enabled. $ export MINIO_ACCESS_KEY=accesskey $ export MINIO_SECRET_KEY=secretkey @@ -85,17 +85,16 @@ EXAMPLES: // Handler for 'minio gateway nas' command line. func nasGatewayMain(ctx *cli.Context) { // Validate gateway arguments. - host := ctx.Args().First() - if host == "help" { + if !ctx.Args().Present() || ctx.Args().First() == "help" { cli.ShowCommandHelpAndExit(ctx, nasBackend, 1) } - // Validate gateway arguments. - minio.StartGateway(ctx, &NAS{host}) + + minio.StartGateway(ctx, &NAS{ctx.Args().First()}) } // NAS implements Gateway. type NAS struct { - host string + path string } // Name implements Gateway interface. @@ -106,7 +105,7 @@ func (g *NAS) Name() string { // NewGatewayLayer returns nas gatewaylayer. func (g *NAS) NewGatewayLayer(creds auth.Credentials) (minio.ObjectLayer, error) { var err error - newObject, err := minio.NewFSObjectLayer(g.host) + newObject, err := minio.NewFSObjectLayer(g.path) if err != nil { return nil, err } diff --git a/cmd/ui-errors.go b/cmd/ui-errors.go index 0480d240a..194e5998e 100644 --- a/cmd/ui-errors.go +++ b/cmd/ui-errors.go @@ -54,6 +54,12 @@ var ( Secret key should be in between 8 and 40 characters.`, ) + uiErrEnvCredentialsMissing = newUIErrFn( + "Credentials missing", + "Please provide correct credentials", + `Access key and Secret key should be specified in Gateway mode from environment variables MINIO_ACCESS_KEY and MINIO_SECRET_KEY respectively.`, + ) + uiErrInvalidErasureEndpoints = newUIErrFn( "Invalid endpoint(s) in erasure mode", "Please provide correct combination of local/remote paths",