diff --git a/controller-main.go b/controller-main.go index 10cc7cd33..52bf4b9f0 100644 --- a/controller-main.go +++ b/controller-main.go @@ -42,7 +42,7 @@ func controllerMain(c *cli.Context) { if c.Args().Present() { cli.ShowCommandHelpAndExit(c, "controller", 1) } - err := controller.StartController() + err := controller.Start() if err != nil { Fatalln(err) } diff --git a/pkg/controller/router.go b/pkg/controller/router.go index db38bf241..10f1ecc9f 100644 --- a/pkg/controller/router.go +++ b/pkg/controller/router.go @@ -20,7 +20,7 @@ import ( "net/http" router "github.com/gorilla/mux" - "github.com/minio/minio/pkg/rpc" + "github.com/minio/minio/pkg/controller/rpc" ) // getRPCHandler rpc handler diff --git a/pkg/rpc/auth.go b/pkg/controller/rpc/auth.go similarity index 100% rename from pkg/rpc/auth.go rename to pkg/controller/rpc/auth.go diff --git a/pkg/rpc/donut.go b/pkg/controller/rpc/donut.go similarity index 100% rename from pkg/rpc/donut.go rename to pkg/controller/rpc/donut.go diff --git a/pkg/rpc/request.go b/pkg/controller/rpc/request.go similarity index 100% rename from pkg/rpc/request.go rename to pkg/controller/rpc/request.go diff --git a/pkg/rpc/server.go b/pkg/controller/rpc/server.go similarity index 100% rename from pkg/rpc/server.go rename to pkg/controller/rpc/server.go diff --git a/pkg/rpc/sysinfo.go b/pkg/controller/rpc/sysinfo.go similarity index 100% rename from pkg/rpc/sysinfo.go rename to pkg/controller/rpc/sysinfo.go diff --git a/pkg/rpc/version.go b/pkg/controller/rpc/version.go similarity index 100% rename from pkg/rpc/version.go rename to pkg/controller/rpc/version.go diff --git a/pkg/controller/rpc_test.go b/pkg/controller/rpc_test.go index 91667b7a6..2404d5175 100644 --- a/pkg/controller/rpc_test.go +++ b/pkg/controller/rpc_test.go @@ -22,7 +22,7 @@ import ( "testing" jsonrpc "github.com/gorilla/rpc/v2/json" - "github.com/minio/minio/pkg/rpc" + "github.com/minio/minio/pkg/controller/rpc" . "gopkg.in/check.v1" ) diff --git a/pkg/controller/server.go b/pkg/controller/server.go index 5a7cbe103..65d922430 100644 --- a/pkg/controller/server.go +++ b/pkg/controller/server.go @@ -54,7 +54,8 @@ func getRPCServer(rpcHandler http.Handler) (*http.Server, *probe.Error) { return httpServer, nil } -func StartController() *probe.Error { +// Start starts a controller +func Start() *probe.Error { rpcServer, err := getRPCServer(getRPCHandler()) if err != nil { return err.Trace() diff --git a/pkg/server/router.go b/pkg/server/router.go index 9d84ca47b..db00f210b 100644 --- a/pkg/server/router.go +++ b/pkg/server/router.go @@ -20,7 +20,6 @@ import ( "net/http" router "github.com/gorilla/mux" - "github.com/minio/minio/pkg/rpc" "github.com/minio/minio/pkg/server/api" ) @@ -72,17 +71,3 @@ func getAPIHandler(conf api.Config) (http.Handler, api.Minio) { apiHandler := registerCustomMiddleware(mux, mwHandlers...) return apiHandler, minioAPI } - -// getRPCHandler rpc handler -func getRPCHandler() http.Handler { - s := rpc.NewServer() - s.RegisterJSONCodec() - // Add new RPC services here - return registerRPC(router.NewRouter(), s) -} - -// registerRPC - register rpc handlers -func registerRPC(mux *router.Router, s *rpc.Server) http.Handler { - mux.Handle("/rpc", s) - return mux -} diff --git a/pkg/server/server.go b/pkg/server/server.go index 82310b9f4..9dc699ae7 100644 --- a/pkg/server/server.go +++ b/pkg/server/server.go @@ -83,17 +83,6 @@ func getAPIServer(conf api.Config, apiHandler http.Handler) (*http.Server, *prob return httpServer, nil } -// getRPCServer instance -func getRPCServer(rpcHandler http.Handler) *http.Server { - // Minio server config - httpServer := &http.Server{ - Addr: ":9001", // TODO make this configurable - Handler: rpcHandler, - MaxHeaderBytes: 1 << 20, - } - return httpServer -} - // Start ticket master func startTM(a api.Minio) { for { @@ -103,18 +92,16 @@ func startTM(a api.Minio) { } } -// StartServices starts basic services for a server -func StartServices(conf api.Config) *probe.Error { +// Start starts a s3 compatible cloud storage server +func Start(conf api.Config) *probe.Error { apiHandler, minioAPI := getAPIHandler(conf) apiServer, err := getAPIServer(conf, apiHandler) if err != nil { return err.Trace() } - rpcServer := getRPCServer(getRPCHandler()) // start ticket master go startTM(minioAPI) - - if err := minhttp.ListenAndServeLimited(conf.RateLimit, apiServer, rpcServer); err != nil { + if err := minhttp.ListenAndServeLimited(conf.RateLimit, apiServer); err != nil { return err.Trace() } return nil diff --git a/server-main.go b/server-main.go index f7f803e59..ae4c630ac 100644 --- a/server-main.go +++ b/server-main.go @@ -60,7 +60,7 @@ func serverMain(c *cli.Context) { cli.ShowCommandHelpAndExit(c, "server", 1) } apiServerConfig := getServerConfig(c) - if err := server.StartServices(apiServerConfig); err != nil { + if err := server.Start(apiServerConfig); err != nil { Fatalln(err.Trace()) } }