move credentials as separate package (#5115)
Bala FA
7 years ago
committed by
Dee Koder
parent
8d584bd819
commit
32c6b62932
@ -1,100 +0,0 @@ |
||||
/* |
||||
* Minio Cloud Storage, (C) 2017 Minio, Inc. |
||||
* |
||||
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||
* you may not use this file except in compliance with the License. |
||||
* You may obtain a copy of the License at |
||||
* |
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
* |
||||
* Unless required by applicable law or agreed to in writing, software |
||||
* distributed under the License is distributed on an "AS IS" BASIS, |
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||
* See the License for the specific language governing permissions and |
||||
* limitations under the License. |
||||
*/ |
||||
|
||||
package cmd |
||||
|
||||
import "testing" |
||||
|
||||
func TestMustGetNewCredential(t *testing.T) { |
||||
cred := mustGetNewCredential() |
||||
if !cred.IsValid() { |
||||
t.Fatalf("Failed to get new valid credential") |
||||
} |
||||
if len(cred.SecretKey) != secretKeyMaxLen { |
||||
t.Fatalf("Invalid length %d of the secretKey credential generated, expected %d", len(cred.SecretKey), secretKeyMaxLen) |
||||
} |
||||
} |
||||
|
||||
func TestCreateCredential(t *testing.T) { |
||||
cred := mustGetNewCredential() |
||||
testCases := []struct { |
||||
accessKey string |
||||
secretKey string |
||||
expectedResult bool |
||||
expectedErr error |
||||
}{ |
||||
// Access key too small (min 5 chars).
|
||||
{"user", "pass", false, errInvalidAccessKeyLength}, |
||||
// Long access key is ok.
|
||||
{"user123456789012345678901234567890", "password", true, nil}, |
||||
// Secret key too small (min 8 chars).
|
||||
{"myuser", "pass", false, errInvalidSecretKeyLength}, |
||||
// Long secret key is ok.
|
||||
{"myuser", "pass1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890", true, nil}, |
||||
{"myuser", "mypassword", true, nil}, |
||||
{cred.AccessKey, cred.SecretKey, true, nil}, |
||||
} |
||||
|
||||
for _, testCase := range testCases { |
||||
cred, err := createCredential(testCase.accessKey, testCase.secretKey) |
||||
if testCase.expectedErr == nil { |
||||
if err != nil { |
||||
t.Fatalf("error: expected = <nil>, got = %v", err) |
||||
} |
||||
} else if err == nil { |
||||
t.Fatalf("error: expected = %v, got = <nil>", testCase.expectedErr) |
||||
} else if testCase.expectedErr.Error() != err.Error() { |
||||
t.Fatalf("error: expected = %v, got = %v", testCase.expectedErr, err) |
||||
} |
||||
|
||||
if testCase.expectedResult != cred.IsValid() { |
||||
t.Fatalf("cred: expected: %v, got: %v", testCase.expectedResult, cred.IsValid()) |
||||
} |
||||
} |
||||
} |
||||
|
||||
func TestCredentialEqual(t *testing.T) { |
||||
cred := mustGetNewCredential() |
||||
testCases := []struct { |
||||
cred credential |
||||
ccred credential |
||||
expectedResult bool |
||||
}{ |
||||
// Empty compare credential
|
||||
{cred, credential{}, false}, |
||||
// Empty credential
|
||||
{credential{}, cred, false}, |
||||
// Two different credentials
|
||||
{cred, mustGetNewCredential(), false}, |
||||
// Access key is different in compare credential.
|
||||
{cred, credential{AccessKey: "myuser", SecretKey: cred.SecretKey}, false}, |
||||
// Secret key is different in compare credential.
|
||||
{cred, credential{AccessKey: cred.AccessKey, SecretKey: "mypassword"}, false}, |
||||
// secretHashKey is missing in compare credential.
|
||||
{cred, credential{AccessKey: cred.AccessKey, SecretKey: cred.SecretKey}, true}, |
||||
// secretHashKey is missing in credential.
|
||||
{credential{AccessKey: cred.AccessKey, SecretKey: cred.SecretKey}, cred, true}, |
||||
// Same credentials.
|
||||
{cred, cred, true}, |
||||
} |
||||
|
||||
for _, testCase := range testCases { |
||||
result := testCase.cred.Equal(testCase.ccred) |
||||
if result != testCase.expectedResult { |
||||
t.Fatalf("cred: expected: %v, got: %v", testCase.expectedResult, result) |
||||
} |
||||
} |
||||
} |
||||
@ -0,0 +1,135 @@ |
||||
/* |
||||
* Minio Cloud Storage, (C) 2017 Minio, Inc. |
||||
* |
||||
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||
* you may not use this file except in compliance with the License. |
||||
* You may obtain a copy of the License at |
||||
* |
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
* |
||||
* Unless required by applicable law or agreed to in writing, software |
||||
* distributed under the License is distributed on an "AS IS" BASIS, |
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||
* See the License for the specific language governing permissions and |
||||
* limitations under the License. |
||||
*/ |
||||
|
||||
package auth |
||||
|
||||
import "testing" |
||||
|
||||
func TestIsAccessKeyValid(t *testing.T) { |
||||
testCases := []struct { |
||||
accessKey string |
||||
expectedResult bool |
||||
}{ |
||||
{alphaNumericTable[:accessKeyMinLen], true}, |
||||
{alphaNumericTable[:accessKeyMinLen+1], true}, |
||||
{alphaNumericTable[:accessKeyMinLen-1], false}, |
||||
} |
||||
|
||||
for i, testCase := range testCases { |
||||
result := IsAccessKeyValid(testCase.accessKey) |
||||
if result != testCase.expectedResult { |
||||
t.Fatalf("test %v: expected: %v, got: %v", i+1, testCase.expectedResult, result) |
||||
} |
||||
} |
||||
} |
||||
|
||||
func TestIsSecretKeyValid(t *testing.T) { |
||||
testCases := []struct { |
||||
secretKey string |
||||
expectedResult bool |
||||
}{ |
||||
{alphaNumericTable[:secretKeyMinLen], true}, |
||||
{alphaNumericTable[:secretKeyMinLen+1], true}, |
||||
{alphaNumericTable[:secretKeyMinLen-1], false}, |
||||
} |
||||
|
||||
for i, testCase := range testCases { |
||||
result := isSecretKeyValid(testCase.secretKey) |
||||
if result != testCase.expectedResult { |
||||
t.Fatalf("test %v: expected: %v, got: %v", i+1, testCase.expectedResult, result) |
||||
} |
||||
} |
||||
} |
||||
|
||||
func TestMustGetNewCredentials(t *testing.T) { |
||||
cred := MustGetNewCredentials() |
||||
if !cred.IsValid() { |
||||
t.Fatalf("Failed to get new valid credential") |
||||
} |
||||
if len(cred.AccessKey) != accessKeyMaxLen { |
||||
t.Fatalf("access key length: expected: %v, got: %v", secretKeyMaxLen, len(cred.AccessKey)) |
||||
} |
||||
if len(cred.SecretKey) != secretKeyMaxLen { |
||||
t.Fatalf("secret key length: expected: %v, got: %v", secretKeyMaxLen, len(cred.SecretKey)) |
||||
} |
||||
} |
||||
|
||||
func TestCreateCredentials(t *testing.T) { |
||||
testCases := []struct { |
||||
accessKey string |
||||
secretKey string |
||||
valid bool |
||||
expectedErr error |
||||
}{ |
||||
// Valid access and secret keys with minimum length.
|
||||
{alphaNumericTable[:accessKeyMinLen], alphaNumericTable[:secretKeyMinLen], true, nil}, |
||||
// Valid access and/or secret keys are longer than minimum length.
|
||||
{alphaNumericTable[:accessKeyMinLen+1], alphaNumericTable[:secretKeyMinLen+1], true, nil}, |
||||
// Smaller access key.
|
||||
{alphaNumericTable[:accessKeyMinLen-1], alphaNumericTable[:secretKeyMinLen], false, ErrInvalidAccessKeyLength}, |
||||
// Smaller secret key.
|
||||
{alphaNumericTable[:accessKeyMinLen], alphaNumericTable[:secretKeyMinLen-1], false, ErrInvalidSecretKeyLength}, |
||||
} |
||||
|
||||
for i, testCase := range testCases { |
||||
cred, err := CreateCredentials(testCase.accessKey, testCase.secretKey) |
||||
|
||||
if err != nil { |
||||
if testCase.expectedErr == nil { |
||||
t.Fatalf("test %v: error: expected = <nil>, got = %v", i+1, err) |
||||
} |
||||
if testCase.expectedErr.Error() != err.Error() { |
||||
t.Fatalf("test %v: error: expected = %v, got = %v", i+1, testCase.expectedErr, err) |
||||
} |
||||
} else { |
||||
if testCase.expectedErr != nil { |
||||
t.Fatalf("test %v: error: expected = %v, got = <nil>", i+1, testCase.expectedErr) |
||||
} |
||||
if !cred.IsValid() { |
||||
t.Fatalf("test %v: got invalid credentials", i+1) |
||||
} |
||||
} |
||||
} |
||||
} |
||||
|
||||
func TestCredentialsEqual(t *testing.T) { |
||||
cred := MustGetNewCredentials() |
||||
testCases := []struct { |
||||
cred Credentials |
||||
ccred Credentials |
||||
expectedResult bool |
||||
}{ |
||||
// Same Credentialss.
|
||||
{cred, cred, true}, |
||||
// Empty credentials to compare.
|
||||
{cred, Credentials{}, false}, |
||||
// Empty credentials.
|
||||
{Credentials{}, cred, false}, |
||||
// Two different credentialss
|
||||
{cred, MustGetNewCredentials(), false}, |
||||
// Access key is different in credentials to compare.
|
||||
{cred, Credentials{AccessKey: "myuser", SecretKey: cred.SecretKey}, false}, |
||||
// Secret key is different in credentials to compare.
|
||||
{cred, Credentials{AccessKey: cred.AccessKey, SecretKey: "mypassword"}, false}, |
||||
} |
||||
|
||||
for i, testCase := range testCases { |
||||
result := testCase.cred.Equal(testCase.ccred) |
||||
if result != testCase.expectedResult { |
||||
t.Fatalf("test %v: expected: %v, got: %v", i+1, testCase.expectedResult, result) |
||||
} |
||||
} |
||||
} |
||||
Loading…
Reference in new issue