From 318265ecaf5fd49f832ccff84d9210c03e11734b Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Wed, 10 Feb 2016 21:22:37 +0530 Subject: [PATCH] jsonrpc: WrapError() makes jsonrpc return unnecessary details in the error message. --- typed-errors.go | 3 +++ web-handlers.go | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/typed-errors.go b/typed-errors.go index 293a85805..3187a9d69 100644 --- a/typed-errors.go +++ b/typed-errors.go @@ -18,6 +18,9 @@ package main import "errors" +// errInvalidCredentials +var errInvalidCredentials = errors.New("Invalid credentials provided") + // errUnAuthorizedRequest - un authorized request. var errUnAuthorizedRequest = errors.New("Unauthorized request") diff --git a/web-handlers.go b/web-handlers.go index bebabca27..90d0d63b8 100644 --- a/web-handlers.go +++ b/web-handlers.go @@ -177,7 +177,7 @@ func (web *WebAPI) PutObjectURL(r *http.Request, args *PutObjectURLArgs, reply * } targetHost, err := getTargetHost(web.apiAddress, args.TargetHost) if err != nil { - return probe.WrapError(err) + return err.ToGoError() } client, e := minio.NewV4(targetHost, web.accessKeyID, web.secretAccessKey, web.inSecure) if e != nil { @@ -206,7 +206,7 @@ func (web *WebAPI) GetObjectURL(r *http.Request, args *GetObjectURLArgs, reply * targetHost, err := getTargetHost(web.apiAddress, args.TargetHost) if err != nil { - return probe.WrapError(err) + return err.ToGoError() } client, e := minio.NewV4(targetHost, web.accessKeyID, web.secretAccessKey, web.inSecure) if e != nil { @@ -239,11 +239,11 @@ func (web *WebAPI) Login(r *http.Request, args *LoginArgs, reply *LoginRep) erro if jwt.Authenticate(args.Username, args.Password) { token, err := jwt.GenerateToken(args.Username) if err != nil { - return probe.WrapError(err.Trace()) + return err.ToGoError() } reply.Token = token reply.UIVersion = uiVersion return nil } - return errUnAuthorizedRequest + return errInvalidCredentials }