From 3064da7b087a9d05be36f363058de7c207642ab0 Mon Sep 17 00:00:00 2001 From: Andreas Auernhammer Date: Mon, 16 Sep 2019 23:27:34 +0200 Subject: [PATCH] return error during part listing when no quorum (#8241) This commit fixes a subtle bug that (probably) caused an issue affecting encrypted multipart objects. When a cluster has no quorum this bug causes `ListObjectParts` to return nil as error instead of a quorum error. Thanks to @harshavardhana for detecting this. --- cmd/xl-v1-multipart.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/xl-v1-multipart.go b/cmd/xl-v1-multipart.go index 437c9475c..c1ae07086 100644 --- a/cmd/xl-v1-multipart.go +++ b/cmd/xl-v1-multipart.go @@ -520,7 +520,7 @@ func (xl xlObjects) ListObjectParts(ctx context.Context, bucket, object, uploadI reducedErr := reduceWriteQuorumErrs(ctx, errs, objectOpIgnoredErrs, writeQuorum) if reducedErr == errXLWriteQuorum { - return result, toObjectErr(err, minioMetaMultipartBucket, uploadIDPath) + return result, toObjectErr(reducedErr, minioMetaMultipartBucket, uploadIDPath) } _, modTime := listOnlineDisks(storageDisks, partsMetadata, errs)