From 1c24c93f737b0833088c1db2adc58ec1b2e94905 Mon Sep 17 00:00:00 2001 From: Anis Elleuch Date: Thu, 15 Nov 2018 21:18:58 +0100 Subject: [PATCH] storage: Upgrade REST version after adding WriteAll API (#6819) Rolling update doesn't work properly because Storage REST API has a new API WriteAll() but without API version number increase. Also be sure to return 404 for unknown http paths. --- cmd/storage-rest-common.go | 2 +- cmd/storage-rest-server.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/storage-rest-common.go b/cmd/storage-rest-common.go index 9b2133af8..ec7dbe5f3 100644 --- a/cmd/storage-rest-common.go +++ b/cmd/storage-rest-common.go @@ -16,7 +16,7 @@ package cmd -const storageRESTVersion = "v1" +const storageRESTVersion = "v2" const storageRESTPath = minioReservedBucketPath + "/storage/" + storageRESTVersion + "/" const ( diff --git a/cmd/storage-rest-server.go b/cmd/storage-rest-server.go index a7735bcb6..f0701864a 100644 --- a/cmd/storage-rest-server.go +++ b/cmd/storage-rest-server.go @@ -378,5 +378,6 @@ func registerStorageRESTHandlers(router *mux.Router, endpoints EndpointList) { subrouter.Methods(http.MethodPost).Path("/" + storageRESTMethodRenameFile).HandlerFunc(httpTraceHdrs(server.RenameFileHandler)). Queries(restQueries(storageRESTSrcVolume, storageRESTSrcPath, storageRESTDstVolume, storageRESTDstPath)...) + subrouter.NotFoundHandler = http.HandlerFunc(httpTraceAll(notFoundHandler)) } }