From 11b8e292a772b2974ad1f45ece3de87120bdf829 Mon Sep 17 00:00:00 2001 From: Krishna Srinivas Date: Fri, 27 Apr 2018 15:03:19 -0700 Subject: [PATCH] Disable logging during unit tests (#5861) --- cmd/logger/logger.go | 10 ++++++++++ cmd/test-utils_test.go | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/cmd/logger/logger.go b/cmd/logger/logger.go index 0862e125e..40d8e37bd 100644 --- a/cmd/logger/logger.go +++ b/cmd/logger/logger.go @@ -37,6 +37,9 @@ var ( colorRed = color.New(color.FgRed).SprintfFunc() ) +// Disable disables all logging, false by default. (used for "go test") +var Disable = false + var trimStrings []string // Level type @@ -79,6 +82,9 @@ type Console interface { } func consoleLog(console Console, msg string, args ...interface{}) { + if Disable { + return + } if jsonFlag { console.json(msg, args...) } else if quiet { @@ -221,6 +227,10 @@ func getTrace(traceLevel int) []string { // LogIf : func LogIf(ctx context.Context, err error) { + if Disable { + return + } + if err == nil { return } diff --git a/cmd/test-utils_test.go b/cmd/test-utils_test.go index 4cbe980f7..b940dfc0c 100644 --- a/cmd/test-utils_test.go +++ b/cmd/test-utils_test.go @@ -75,7 +75,7 @@ func init() { // Set system resources to maximum. setMaxResources() - logger.EnableQuiet() + logger.Disable = true } // concurreny level for certain parallel tests.