You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
107 lines
3.6 KiB
107 lines
3.6 KiB
From 2587791d57588562c21e5ef7e678f02ab2f3eb82 Mon Sep 17 00:00:00 2001
|
|
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Date: Tue, 22 Jan 2019 16:21:34 +0100
|
|
Subject: [PATCH 14/28] rt2x00: no need to check return value of debugfs_create
|
|
functions
|
|
|
|
When calling debugfs functions, there is no need to ever check the
|
|
return value. The function can work or not, but the code logic should
|
|
never do something different based on this.
|
|
|
|
Cc: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
Cc: Helmut Schaa <helmut.schaa@googlemail.com>
|
|
Cc: Kalle Valo <kvalo@codeaurora.org>
|
|
Cc: linux-wireless@vger.kernel.org
|
|
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
|
|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
|
---
|
|
.../net/wireless/ralink/rt2x00/rt2x00debug.c | 27 -------------------
|
|
1 file changed, 27 deletions(-)
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00debug.c
|
|
@@ -656,36 +656,24 @@ void rt2x00debug_register(struct rt2x00_
|
|
intf->driver_folder =
|
|
debugfs_create_dir(intf->rt2x00dev->ops->name,
|
|
rt2x00dev->hw->wiphy->debugfsdir);
|
|
- if (IS_ERR(intf->driver_folder) || !intf->driver_folder)
|
|
- goto exit;
|
|
|
|
intf->driver_entry =
|
|
rt2x00debug_create_file_driver("driver", intf, &intf->driver_blob);
|
|
- if (IS_ERR(intf->driver_entry) || !intf->driver_entry)
|
|
- goto exit;
|
|
|
|
intf->chipset_entry =
|
|
rt2x00debug_create_file_chipset("chipset",
|
|
intf, &intf->chipset_blob);
|
|
- if (IS_ERR(intf->chipset_entry) || !intf->chipset_entry)
|
|
- goto exit;
|
|
|
|
intf->dev_flags = debugfs_create_file("dev_flags", 0400,
|
|
intf->driver_folder, intf,
|
|
&rt2x00debug_fop_dev_flags);
|
|
- if (IS_ERR(intf->dev_flags) || !intf->dev_flags)
|
|
- goto exit;
|
|
|
|
intf->cap_flags = debugfs_create_file("cap_flags", 0400,
|
|
intf->driver_folder, intf,
|
|
&rt2x00debug_fop_cap_flags);
|
|
- if (IS_ERR(intf->cap_flags) || !intf->cap_flags)
|
|
- goto exit;
|
|
|
|
intf->register_folder =
|
|
debugfs_create_dir("register", intf->driver_folder);
|
|
- if (IS_ERR(intf->register_folder) || !intf->register_folder)
|
|
- goto exit;
|
|
|
|
#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
|
|
({ \
|
|
@@ -695,9 +683,6 @@ void rt2x00debug_register(struct rt2x00_
|
|
0600, \
|
|
(__intf)->register_folder, \
|
|
&(__intf)->offset_##__name); \
|
|
- if (IS_ERR((__intf)->__name##_off_entry) || \
|
|
- !(__intf)->__name##_off_entry) \
|
|
- goto exit; \
|
|
\
|
|
(__intf)->__name##_val_entry = \
|
|
debugfs_create_file(__stringify(__name) "_value", \
|
|
@@ -705,9 +690,6 @@ void rt2x00debug_register(struct rt2x00_
|
|
(__intf)->register_folder, \
|
|
(__intf), \
|
|
&rt2x00debug_fop_##__name); \
|
|
- if (IS_ERR((__intf)->__name##_val_entry) || \
|
|
- !(__intf)->__name##_val_entry) \
|
|
- goto exit; \
|
|
} \
|
|
})
|
|
|
|
@@ -721,15 +703,10 @@ void rt2x00debug_register(struct rt2x00_
|
|
|
|
intf->queue_folder =
|
|
debugfs_create_dir("queue", intf->driver_folder);
|
|
- if (IS_ERR(intf->queue_folder) || !intf->queue_folder)
|
|
- goto exit;
|
|
|
|
intf->queue_frame_dump_entry =
|
|
debugfs_create_file("dump", 0400, intf->queue_folder,
|
|
intf, &rt2x00debug_fop_queue_dump);
|
|
- if (IS_ERR(intf->queue_frame_dump_entry)
|
|
- || !intf->queue_frame_dump_entry)
|
|
- goto exit;
|
|
|
|
skb_queue_head_init(&intf->frame_dump_skbqueue);
|
|
init_waitqueue_head(&intf->frame_dump_waitqueue);
|
|
@@ -747,10 +724,6 @@ void rt2x00debug_register(struct rt2x00_
|
|
#endif
|
|
|
|
return;
|
|
-
|
|
-exit:
|
|
- rt2x00debug_deregister(rt2x00dev);
|
|
- rt2x00_err(rt2x00dev, "Failed to register debug handler\n");
|
|
}
|
|
|
|
void rt2x00debug_deregister(struct rt2x00_dev *rt2x00dev)
|
|
|