You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
31 lines
1.3 KiB
31 lines
1.3 KiB
From e2d8f646c79f26e094bfaf9b21be614d1e148a67 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
|
Date: Wed, 17 Aug 2016 23:11:52 +0200
|
|
Subject: [PATCH] net: bgmac: make it clear when setting interface type to RMII
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is
|
|
equal to 0. It make code a bit clener, so far when reading it one could
|
|
think we forgot to set a proper mode. It also keeps this mode code in
|
|
sync with other ones.
|
|
|
|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
--- a/drivers/net/ethernet/broadcom/bgmac.c
|
|
+++ b/drivers/net/ethernet/broadcom/bgmac.c
|
|
@@ -935,7 +935,8 @@ static void bgmac_chip_reset(struct bgma
|
|
et_swtype <<= 4;
|
|
sw_type = et_swtype;
|
|
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_EPHYRMII) {
|
|
- sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
|
|
+ sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RMII |
|
|
+ BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
|
|
} else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_RGMII) {
|
|
sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
|
|
BGMAC_CHIPCTL_1_SW_TYPE_RGMII;
|
|
|