Signed-off-by: Rafał Miłecki <rafal@milecki.pl>master
parent
4491979dc9
commit
99d3774a3c
@ -0,0 +1,55 @@ |
||||
From f4737a62033d7f3e0db740c449fc62119da7ab8a Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||
Date: Mon, 30 Jan 2017 16:09:51 +0100
|
||||
Subject: [PATCH] brcmfmac: check brcmf_bus_get_memdump result for error
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
This method may be unsupported (see: USB bus) or may just fail (see:
|
||||
SDIO bus).
|
||||
While at it rework logic in brcmf_sdio_bus_get_memdump function to avoid
|
||||
too many conditional code nesting levels.
|
||||
|
||||
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
|
||||
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
||||
---
|
||||
.../wireless/broadcom/brcm80211/brcmfmac/debug.c | 23 +++++++++++++++-------
|
||||
1 file changed, 16 insertions(+), 7 deletions(-)
|
||||
|
||||
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
|
||||
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
|
||||
@@ -32,16 +32,25 @@ static int brcmf_debug_create_memdump(st
|
||||
{
|
||||
void *dump;
|
||||
size_t ramsize;
|
||||
+ int err;
|
||||
|
||||
ramsize = brcmf_bus_get_ramsize(bus);
|
||||
- if (ramsize) {
|
||||
- dump = vzalloc(len + ramsize);
|
||||
- if (!dump)
|
||||
- return -ENOMEM;
|
||||
- memcpy(dump, data, len);
|
||||
- brcmf_bus_get_memdump(bus, dump + len, ramsize);
|
||||
- dev_coredumpv(bus->dev, dump, len + ramsize, GFP_KERNEL);
|
||||
+ if (!ramsize)
|
||||
+ return -ENOTSUPP;
|
||||
+
|
||||
+ dump = vzalloc(len + ramsize);
|
||||
+ if (!dump)
|
||||
+ return -ENOMEM;
|
||||
+
|
||||
+ memcpy(dump, data, len);
|
||||
+ err = brcmf_bus_get_memdump(bus, dump + len, ramsize);
|
||||
+ if (err) {
|
||||
+ vfree(dump);
|
||||
+ return err;
|
||||
}
|
||||
+
|
||||
+ dev_coredumpv(bus->dev, dump, len + ramsize, GFP_KERNEL);
|
||||
+
|
||||
return 0;
|
||||
}
|
||||
|
@ -0,0 +1,41 @@ |
||||
From 36401cb7ffae731295a6dd1ce2b40d7ad74245f4 Mon Sep 17 00:00:00 2001
|
||||
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||||
Date: Mon, 30 Jan 2017 16:09:52 +0100
|
||||
Subject: [PATCH] brcmfmac: be more verbose when PSM's watchdog fires
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
It's important to inform user so he knows things went wrong. He may also
|
||||
want to get memory dump for further debugging purposes.
|
||||
|
||||
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
|
||||
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
|
||||
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
|
||||
---
|
||||
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c | 12 ++++++++++--
|
||||
1 file changed, 10 insertions(+), 2 deletions(-)
|
||||
|
||||
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
|
||||
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
|
||||
@@ -58,10 +58,18 @@ static int brcmf_debug_psm_watchdog_noti
|
||||
const struct brcmf_event_msg *evtmsg,
|
||||
void *data)
|
||||
{
|
||||
+ int err;
|
||||
+
|
||||
brcmf_dbg(TRACE, "enter: bsscfgidx=%d\n", ifp->bsscfgidx);
|
||||
|
||||
- return brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
|
||||
- evtmsg->datalen);
|
||||
+ brcmf_err("PSM's watchdog has fired!\n");
|
||||
+
|
||||
+ err = brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
|
||||
+ evtmsg->datalen);
|
||||
+ if (err)
|
||||
+ brcmf_err("Failed to get memory dump, %d\n", err);
|
||||
+
|
||||
+ return err;
|
||||
}
|
||||
|
||||
void brcmf_debugfs_init(void)
|
Loading…
Reference in new issue