You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
37 lines
1.2 KiB
37 lines
1.2 KiB
9 years ago
|
From 6cf7d8453b9ef0a1e51144969141a92dade6b540 Mon Sep 17 00:00:00 2001
|
||
|
9 years ago
|
From: Arnd Bergmann <arnd@arndb.de>
|
||
|
|
Date: Mon, 14 Mar 2016 15:07:11 +0100
|
||
|
9 years ago
|
Subject: [PATCH 68/91] net: mediatek: remove incorrect dma_mask assignment
|
||
|
9 years ago
|
|
||
|
|
Device drivers should not mess with the DMA mask directly,
|
||
|
|
but instead call dma_set_mask() etc if needed.
|
||
|
|
|
||
|
|
In case of the mtk_eth_soc driver, the mask already gets set
|
||
|
|
correctly when the device is created, and setting it again
|
||
|
|
is against the documented API.
|
||
|
|
|
||
|
|
This removes the incorrect setting.
|
||
|
|
|
||
|
|
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
|
||
|
|
---
|
||
|
|
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 ---
|
||
|
|
1 file changed, 3 deletions(-)
|
||
|
|
|
||
|
9 years ago
|
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
||
|
|
index a005bc4..fcd4ed7 100644
|
||
|
9 years ago
|
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
||
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
||
|
9 years ago
|
@@ -1678,9 +1678,6 @@ static int mtk_probe(struct platform_device *pdev)
|
||
|
9 years ago
|
struct mtk_eth *eth;
|
||
|
|
int err;
|
||
|
|
|
||
|
|
- pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
|
||
|
|
- pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
|
||
|
|
-
|
||
|
|
device_reset(&pdev->dev);
|
||
|
|
|
||
|
|
match = of_match_device(of_mtk_match, &pdev->dev);
|
||
|
9 years ago
|
--
|
||
|
|
1.7.10.4
|
||
|
|
|