You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
43 lines
1.4 KiB
43 lines
1.4 KiB
8 years ago
|
From 807c16253319ee6ccf8873ae64f070f7eb532cd5 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Jo=C3=ABl=20Esponde?= <joel.esponde@honeywell.com>
|
||
|
|
Date: Wed, 23 Nov 2016 12:47:40 +0100
|
||
|
|
Subject: [PATCH] mtd: spi-nor: fix spansion quad enable
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
With the S25FL127S nor flash part, each writing to the configuration
|
||
|
|
register takes hundreds of ms. During that time, no more accesses to
|
||
|
|
the flash should be done (even reads).
|
||
|
|
|
||
|
|
This commit adds a wait loop after the register writing until the flash
|
||
|
|
finishes its work.
|
||
|
|
|
||
|
|
This issue could make rootfs mounting fail when the latter was done too
|
||
|
|
much closely to this quad enable bit setting step. And in this case, a
|
||
|
|
driver as UBIFS may try to recover the filesystem and may broke it
|
||
|
|
completely.
|
||
|
|
|
||
|
|
Signed-off-by: Joël Esponde <joel.esponde@honeywell.com>
|
||
|
|
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
|
||
|
|
---
|
||
|
|
drivers/mtd/spi-nor/spi-nor.c | 7 +++++++
|
||
|
|
1 file changed, 7 insertions(+)
|
||
|
|
|
||
|
|
--- a/drivers/mtd/spi-nor/spi-nor.c
|
||
|
|
+++ b/drivers/mtd/spi-nor/spi-nor.c
|
||
|
8 years ago
|
@@ -1256,6 +1256,13 @@ static int spansion_quad_enable(struct s
|
||
|
|
return -EINVAL;
|
||
|
8 years ago
|
}
|
||
|
|
|
||
|
|
+ ret = spi_nor_wait_till_ready(nor);
|
||
|
|
+ if (ret) {
|
||
|
|
+ dev_err(nor->dev,
|
||
|
|
+ "timeout while writing configuration register\n");
|
||
|
|
+ return ret;
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
/* read back and check it */
|
||
|
|
ret = read_cr(nor);
|
||
|
|
if (!(ret > 0 && (ret & CR_QUAD_EN_SPAN))) {
|