You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
|
|
|
|
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
|
|
|
|
|
Date: Mon, 20 Apr 2015 21:07:48 +0200
|
|
|
|
|
Subject: [PATCH] pppoe: Lacks DST MAC address check
|
|
|
|
|
|
|
|
|
|
A pppoe session is identified by its session ID and MAC address.
|
|
|
|
|
Currently pppoe does not check if the received pkg has the correct
|
|
|
|
|
MAC address. This is a problem when the eth I/F is in promisc mode
|
|
|
|
|
as then any DST MAC address is accepted.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
|
|
|
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/ppp/pppoe.c
|
|
|
|
|
+++ b/drivers/net/ppp/pppoe.c
|
|
|
|
|
@@ -379,6 +379,9 @@ static int pppoe_rcv_core(struct sock *s
|
|
|
|
|
* can't change.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
+ if (skb->pkt_type == PACKET_OTHERHOST)
|
|
|
|
|
+ goto abort_kfree;
|
|
|
|
|
+
|
|
|
|
|
if (sk->sk_state & PPPOX_BOUND) {
|
|
|
|
|
ppp_input(&po->chan, skb);
|
|
|
|
|
} else if (sk->sk_state & PPPOX_RELAY) {
|
