You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Akihiko Odaki ae871c4d46 Make Array-creation behavior of Paginable more predictable (#14687) ... * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - 552e886b64 - b63ede5005 - 64ef37b89d To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.		4 years ago
..
account_associations.rb	…
account_avatar.rb	…
account_counters.rb	…
account_finder_concern.rb	…
account_header.rb	…
account_interactions.rb	Add user notes on accounts (#14148)	4 years ago
attachmentable.rb	Fix remote files not using Content-Type header, streaming (#14184)	4 years ago
cacheable.rb	Fix cache_associated no longer working (#7320)	7 years ago
domain_normalizable.rb	Fix admin page crashing when trying to block an invalid domain name (#13884)	5 years ago
expireable.rb	Fix poll update handler calling method was that was not available (#10246)	6 years ago
ldap_authenticable.rb	…
omniauthable.rb	Fix rubocop warning (#14288)	4 years ago
paginable.rb	Make Array-creation behavior of Paginable more predictable (#14687)	4 years ago
pam_authenticable.rb	…
rate_limitable.rb	…
redisable.rb	…
relationship_cacheable.rb	…
remotable.rb	Fix movie width and frame_rate returning nil (#14357)	4 years ago
status_threading_concern.rb	…
user_roles.rb	…