e8d41bc2fe
Add WebAuthn as an alternative 2FA method ( #14466 )
...
* feat: add possibility of adding WebAuthn security keys to use as 2FA
This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor
to the Settings page for editing the 2FA methods – now it will list the
methods that are available to the user (TOTP and WebAuthn) and from
there they'll be able to add or remove any of them.
Also, it's worth mentioning that for enabling WebAuthn it's required to
have TOTP enabled, so the first time that you go to the 2FA Settings
page, you'll be asked to set it up.
This work was inspired by the one donde by Github in their platform, and
despite it could be approached in different ways, we decided to go with
this one given that we feel that this gives a great UX.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add request for WebAuthn as second factor at login if enabled
This commits adds the feature for using WebAuthn as a second factor for
login when enabled.
If users have WebAuthn enabled, now a page requesting for the use of a
WebAuthn credential for log in will appear, although a link redirecting
to the old page for logging in using a two-factor code will also be
present.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add possibility of deleting WebAuthn Credentials
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: disable WebAuthn when an Admin disables 2FA for a user
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: remove ability to disable TOTP leaving only WebAuthn as 2FA
Following examples form other platforms like Github, we decided to make
Webauthn 2FA secondary to 2FA with TOTP, so that we removed the
possibility of removing TOTP authentication only, leaving users with
just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA'
in order to remove second factor auth.
The reason for WebAuthn being secondary to TOPT is that in that way,
users will still be able to log in using their code from their phone's
application if they don't have their security keys with them – or maybe
even lost them.
* We had to change a little the flow for setting up TOTP, given that now
it's possible to setting up again if you already had TOTP, in order to
let users modify their authenticator app – given that now it's not
possible for them to disable TOTP and set it up again with another
authenticator app.
So, basically, now instead of storing the new `otp_secret` in the
user, we store it in the session until the process of set up is
finished.
This was because, as it was before, when users clicked on 'Edit' in
the new two-factor methods lists page, but then went back without
finishing the flow, their `otp_secret` had been changed therefore
invalidating their previous authenticator app, making them unable to
log in again using TOTP.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* refactor: fix eslint errors
The PR build was failing given that linting returning some errors.
This commit attempts to fix them.
* refactor: normalize i18n translations
The build was failing given that i18n translations files were not
normalized.
This commits fixes that.
* refactor: avoid having the webauthn gem locked to a specific version
* refactor: use symbols for routes without '/'
* refactor: avoid sending webauthn disabled email when 2FA is disabled
When an admins disable 2FA for users, we were sending two mails
to them, one notifying that 2FA was disabled and the other to notify
that WebAuthn was disabled.
As the second one is redundant since the first email includes it, we can
remove it and send just one email to users.
* refactor: avoid creating new env variable for webauthn_origin config
* refactor: improve flash error messages for webauthn pages
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
4 years ago
a3ec9af9b0
Fix: also use custom private boost icon for detailed status ( #14471 )
...
* use custom private boost icon for detail status
* only use className
4 years ago
720214feb0
Add support for inlined objects in activity audience ( #14514 )
...
* Add support for inlined objects in activity audience
* Add tests
4 years ago
9669557be1
Better manage subscriptionCounters ( #14608 )
...
Before this change:
- unsubscribe() was not called for a disconnection
- It seems that WebSocketClient calls connected() and reconnected().
subscriptionCounters were incremented twice for a single reconnection,
first from connected() and second from reconnected()
This might be a an additional change to
https://github.com/tootsuite/mastodon/pull/14579
to recover subscriptions after a reconnect.
4 years ago
46210a65d1
reword "boost to original audience" as per #14596 ( #14598 )
4 years ago
debf6ae316
Fix click range discrepancies in gifv ( #14615 )
4 years ago
92e6b2b4d8
Bump jest-cli from 26.4.0 to 26.4.2 ( #14614 )
...
Bumps [jest-cli](https://github.com/facebook/jest/tree/HEAD/packages/jest-cli ) from 26.4.0 to 26.4.2.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v26.4.2/packages/jest-cli )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
0362cff5d6
Bump jsdom from 16.3.0 to 16.4.0 ( #14587 )
...
Bumps [jsdom](https://github.com/jsdom/jsdom ) from 16.3.0 to 16.4.0.
- [Release notes](https://github.com/jsdom/jsdom/releases )
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md )
- [Commits](https://github.com/jsdom/jsdom/compare/16.3.0...16.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c7cfd4e67a
Fix scrolling issues when closing some dropdown menus ( #14606 )
4 years ago
9b2648b30a
Bump simplecov from 0.18.5 to 0.19.0 ( #14590 )
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.18.5 to 0.19.0.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.18.5...v0.19.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
36e2e9bed5
Bump duplexer from 0.1.1 to 0.1.2 ( #14593 )
...
Bumps [duplexer](https://github.com/Raynos/duplexer ) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/Raynos/duplexer/releases )
- [Commits](https://github.com/Raynos/duplexer/compare/v0.1.1...v0.1.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
e2e316aa53
Bump portfinder from 1.0.26 to 1.0.28 ( #14594 )
...
Bumps [portfinder](https://github.com/http-party/node-portfinder ) from 1.0.26 to 1.0.28.
- [Release notes](https://github.com/http-party/node-portfinder/releases )
- [Commits](https://github.com/http-party/node-portfinder/compare/v1.0.26...v1.0.28 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c5092f8b62
Bump webpacker from 5.1.1 to 5.2.0 ( #14586 )
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.1.1...v5.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
429de48d56
Bump intersection-observer from 0.10.0 to 0.11.0 ( #14589 )
...
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver ) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases )
- [Commits](https://github.com/w3c/IntersectionObserver/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c1dbcd0ba7
Bump aws-sigv4 from 1.2.1 to 1.2.2 ( #14588 )
...
Bumps [aws-sigv4](https://github.com/aws/aws-sdk-ruby ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sigv4/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.2.1...1.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
36289b6a61
Bump redis-rack from 2.1.2 to 2.1.3 ( #14584 )
...
Bumps [redis-rack](http://redis-store.org/redis-rack ) from 2.1.2 to 2.1.3.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
8ba7922639
Bump aws-sdk-s3 from 1.76.0 to 1.78.0 ( #14583 )
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.76.0 to 1.78.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c93a4b792e
Bump jest from 26.2.2 to 26.4.0 ( #14585 )
...
Bumps [jest](https://github.com/facebook/jest ) from 26.2.2 to 26.4.0.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v26.2.2...v26.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
919a554efa
Bump bootsnap from 1.4.7 to 1.4.8 ( #14581 )
...
Bumps [bootsnap](https://github.com/Shopify/bootsnap ) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/Shopify/bootsnap/releases )
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.7...v1.4.8 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
65ebf3ba4e
Bump har-validator from 5.1.3 to 5.1.5 ( #14580 )
...
Bumps [har-validator](https://github.com/ahmadnassri/node-har-validator ) from 5.1.3 to 5.1.5.
- [Release notes](https://github.com/ahmadnassri/node-har-validator/releases )
- [Changelog](https://github.com/ahmadnassri/node-har-validator/blob/master/.releaserc )
- [Commits](https://github.com/ahmadnassri/node-har-validator/compare/v5.1.3...v5.1.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
f6a82cb2cd
Fix not being able to unbookmark toots when blocked by their author ( #14604 )
...
* Fix not being able to unbookmark toots when blocked by their author
* Add tests
4 years ago
62a45ae26e
Fix client-side form validation not accepting handles with uppercase letters ( #14599 )
4 years ago
8930841716
Bump aws-partitions from 1.353.0 to 1.356.0 ( #14578 )
...
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby ) from 1.353.0 to 1.356.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
55e07d9840
Bump tty-color from 0.5.1 to 0.5.2 ( #14547 )
...
Bumps [tty-color](https://github.com/piotrmurach/tty-color ) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/piotrmurach/tty-color/releases )
- [Changelog](https://github.com/piotrmurach/tty-color/blob/master/CHANGELOG.md )
- [Commits](https://github.com/piotrmurach/tty-color/compare/v0.5.1...v0.5.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
9a1160c525
Bump abab from 2.0.3 to 2.0.4 ( #14550 )
...
Bumps [abab](https://github.com/jsdom/abab ) from 2.0.3 to 2.0.4.
- [Release notes](https://github.com/jsdom/abab/releases )
- [Changelog](https://github.com/jsdom/abab/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jsdom/abab/compare/2.0.3...2.0.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c3cb6b1151
Bump fugit from 1.3.6 to 1.3.8 ( #14548 )
...
Bumps [fugit](https://github.com/floraison/fugit ) from 1.3.6 to 1.3.8.
- [Release notes](https://github.com/floraison/fugit/releases )
- [Changelog](https://github.com/floraison/fugit/blob/master/CHANGELOG.md )
- [Commits](https://github.com/floraison/fugit/compare/v1.3.6...v1.3.8 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
b046566d20
Bump jest-haste-map from 26.1.0 to 26.2.2 ( #14552 )
...
Bumps [jest-haste-map](https://github.com/facebook/jest/tree/HEAD/packages/jest-haste-map ) from 26.1.0 to 26.2.2.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v26.2.2/packages/jest-haste-map )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
c917b53c53
Bump pkg-config from 1.4.1 to 1.4.2 ( #14549 )
...
Bumps [pkg-config](https://github.com/ruby-gnome/pkg-config ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/ruby-gnome/pkg-config/releases )
- [Changelog](https://github.com/ruby-gnome/pkg-config/blob/master/NEWS )
- [Commits](https://github.com/ruby-gnome/pkg-config/compare/1.4.1...1.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
24b8a7af41
Bump premailer from 1.12.1 to 1.13.1 ( #14544 )
...
Bumps [premailer](https://github.com/premailer/premailer ) from 1.12.1 to 1.13.1.
- [Release notes](https://github.com/premailer/premailer/releases )
- [Changelog](https://github.com/premailer/premailer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/premailer/premailer/compare/v1.12.1...v1.13.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
fd31509c53
Bump chunky_png from 1.3.11 to 1.3.12 ( #14545 )
...
Bumps [chunky_png](https://github.com/wvanbergen/chunky_png ) from 1.3.11 to 1.3.12.
- [Release notes](https://github.com/wvanbergen/chunky_png/releases )
- [Changelog](https://github.com/wvanbergen/chunky_png/blob/master/CHANGELOG.rdoc )
- [Commits](https://github.com/wvanbergen/chunky_png/compare/v1.3.11...v1.3.12 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
f74c373663
Bump rdf from 3.1.4 to 3.1.5 ( #14543 )
...
Bumps [rdf](https://github.com/ruby-rdf/rdf ) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/ruby-rdf/rdf/releases )
- [Changelog](https://github.com/ruby-rdf/rdf/blob/develop/CHANGES.md )
- [Commits](https://github.com/ruby-rdf/rdf/compare/3.1.4...3.1.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
eceef67f67
Bump use-latest from 1.0.0 to 1.1.0 ( #14541 )
...
Bumps [use-latest](https://github.com/Andarist/use-latest ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/Andarist/use-latest/releases )
- [Commits](https://github.com/Andarist/use-latest/compare/v1.0.0...v1.1.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
f5b87ac4db
Bump aws-sdk-s3 from 1.75.0 to 1.76.0 ( #14542 )
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.75.0 to 1.76.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
8a9d9509ec
Bump brakeman from 4.8.2 to 4.9.0 ( #14540 )
...
Bumps [brakeman](https://github.com/presidentbeef/brakeman ) from 4.8.2 to 4.9.0.
- [Release notes](https://github.com/presidentbeef/brakeman/releases )
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md )
- [Commits](https://github.com/presidentbeef/brakeman/compare/v4.8.2...v4.9.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
4d67df6155
Bump concurrent-ruby from 1.1.6 to 1.1.7 ( #14539 )
...
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby ) from 1.1.6 to 1.1.7.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases )
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.1.6...v1.1.7 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
2eabfdaf24
Bump @babel/core from 7.10.5 to 7.11.1 ( #14554 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.10.5 to 7.11.1.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.11.1/packages/babel-core )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
a55ad84251
Remove dependency on unused and unmaintained http_parser.rb gem ( #14574 )
...
It seems that years ago, the “http” gem dependend on the “http_parser.rb” gem
(it now depends on the “http-parser” gem), and, still years ago, we pulled
it from git in order to benefit from a bugfix that wasn't released yet (#7467 ).
4 years ago
0f38f9726a
Fix hardcoded non-breaking space in public view ( #14568 )
4 years ago
01647b8acb
Fix destructuring error when unsubscribing without subscribing ( #14566 )
4 years ago
8d217d7231
Improve email address validation ( #14565 )
...
* Increase DNS timeout from 1 second to 5 seconds for MX check
1 seconds is rather short when using a recursive DNS resolver which
hasn't got a cached result already available. Use 5 seconds instead,
which is the timeout value we use for outgoing HTTP queries.
* Add more precise error messages for invalid e-mail addresses
4 years ago
7dc4c74265
Add client-side validation in password change forms ( #14564 )
...
* Fix client-side username validation at registration
It used the Account::USERNAME_RE regexp which is for *remote* users,
local user validation is stricter. Also take into account max username length.
* Add client-side form validation for password change
* Add client-side form validation to dedicated registration form
Previous changes only applied to the /about page, not the dedicated form on
/auth
4 years ago
d70c3ab4c3
Add HTML form validation for the registration form ( #14560 )
...
* Add HTML-level validation of username in sign-up form
* Make required fields with incorrect values more visible
* Enable HTML form validation for the registration form
* Mark agreement checkbox as required client-side
* Add minimum length to password
* Add client-side password confirmation validation
4 years ago
ef057584fd
Add support for managing multiple stream subscriptions in a single connection ( #14524 )
4 years ago
decc5b9a78
Fix `tootctl media` commands not handling snowflake ids for media_attachments ( #14536 )
4 years ago
1326c57506
Use default :edit routing ( #14535 )
4 years ago
8b61bb1c3e
Cache result of SQL ( #14534 )
4 years ago
bd3420b139
Fix crash when failing to load emoji picker ( #14525 )
...
Fixes #14523
4 years ago
4a4d08f3a0
Fix eslint error ( #14521 )
4 years ago
b61e060501
Bump node-notifier from 7.0.1 to 7.0.2 ( #14499 )
...
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier ) from 7.0.1 to 7.0.2.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases )
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v7.0.1...v7.0.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
a37d9b6268
Bump minipass-pipeline from 1.2.3 to 1.2.4 ( #14504 )
...
Bumps minipass-pipeline from 1.2.3 to 1.2.4.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years ago
santiagorodriguez96