Prevent multiple handlers for Delete of Actor from running (#9292)

master
Eugen Rochko 6 years ago committed by GitHub
parent 074960bb0f
commit 9311430ed7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      app/lib/activitypub/activity.rb
  2. 6
      app/lib/activitypub/activity/delete.rb

@ -129,4 +129,10 @@ class ActivityPub::Activity
::FetchRemoteStatusService.new.call(@object['url']) ::FetchRemoteStatusService.new.call(@object['url'])
end end
end end
def lock_or_return(key, expire_after = 7.days.seconds)
yield if redis.set(key, true, nx: true, ex: expire_after)
ensure
redis.del(key)
end
end end

@ -12,8 +12,10 @@ class ActivityPub::Activity::Delete < ActivityPub::Activity
private private
def delete_person def delete_person
SuspendAccountService.new.call(@account) lock_or_return("delete_in_progress:#{@account.id}") do
@account.destroy! SuspendAccountService.new.call(@account)
@account.destroy!
end
end end
def delete_note def delete_note

Loading…
Cancel
Save