From 53c86b29f05049d77d17a35a0ca6287174431783 Mon Sep 17 00:00:00 2001 From: David Yip Date: Sun, 3 Dec 2017 21:49:55 -0600 Subject: [PATCH] Glitch::FilterHelper -> Glitch::KeywordMuteHelper. #234. The class helps out with keyword mutes, not just some general concept of "filtering". --- app/lib/feed_manager.rb | 2 +- .../glitch/{filter_helper.rb => keyword_mute_helper.rb} | 4 ++-- .../{filter_helper_spec.rb => keyword_mute_helper_spec.rb} | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) rename app/models/glitch/{filter_helper.rb => keyword_mute_helper.rb} (88%) rename spec/models/glitch/{filter_helper_spec.rb => keyword_mute_helper_spec.rb} (93%) diff --git a/app/lib/feed_manager.rb b/app/lib/feed_manager.rb index 7507b37d2..c16b25635 100644 --- a/app/lib/feed_manager.rb +++ b/app/lib/feed_manager.rb @@ -178,7 +178,7 @@ class FeedManager end def keyword_filter?(status, receiver_id) - Glitch::FilterHelper.new(receiver_id).matches?(status) + Glitch::KeywordMuteHelper.new(receiver_id).matches?(status) end def filter_from_mentions?(status, receiver_id) diff --git a/app/models/glitch/filter_helper.rb b/app/models/glitch/keyword_mute_helper.rb similarity index 88% rename from app/models/glitch/filter_helper.rb rename to app/models/glitch/keyword_mute_helper.rb index 11be877c1..1b8c64e4e 100644 --- a/app/models/glitch/filter_helper.rb +++ b/app/models/glitch/keyword_mute_helper.rb @@ -1,6 +1,6 @@ require 'htmlentities' -class Glitch::FilterHelper +class Glitch::KeywordMuteHelper include ActionView::Helpers::SanitizeHelper attr_reader :text_matcher @@ -26,6 +26,6 @@ class Glitch::FilterHelper end def prepare_text(text) - entity_decoder.decode(strip_tags(text)) + entity_decoder.decode(strip_tags(text)).tap { |x| puts x } end end diff --git a/spec/models/glitch/filter_helper_spec.rb b/spec/models/glitch/keyword_mute_helper_spec.rb similarity index 93% rename from spec/models/glitch/filter_helper_spec.rb rename to spec/models/glitch/keyword_mute_helper_spec.rb index 9a808667d..9d09e58da 100644 --- a/spec/models/glitch/filter_helper_spec.rb +++ b/spec/models/glitch/keyword_mute_helper_spec.rb @@ -1,9 +1,9 @@ require 'rails_helper' -RSpec.describe Glitch::FilterHelper do +RSpec.describe Glitch::KeywordMuteHelper do describe '#matches?' do let(:alice) { Fabricate(:account, username: 'alice').tap(&:save!) } - let(:helper) { Glitch::FilterHelper.new(alice) } + let(:helper) { Glitch::KeywordMuteHelper.new(alice) } it 'ignores names of HTML tags in status text' do status = Fabricate(:status, text: 'uh example')