add an explanatory comment to AccountInteractions

7 years ago · 211f0a9513
parent 4a527154b7
commit 211f0a9513
1 changed files with 1 additions and 0 deletions
--- a/app/models/concerns/account_interactions.rb
+++ b/app/models/concerns/account_interactions.rb
@ -76,6 +76,7 @@ module AccountInteractions

  def mute!(other_account, notifications: true)
    mute = mute_relationships.create_with(hide_notifications: notifications).find_or_create_by!(target_account: other_account)
+    # When toggling a mute between hiding and allowing notifications, the mute will already exist, so the find_or_create_by! call will return the existing Mute without updating the hide_notifications attribute. Therefore, we check that hide_notifications? is what we want and set it if it isn't.
    if mute.hide_notifications? != notifications
      mute.hide_notifications = notifications
      mute.save!