Fix caching headers in ActivityPub endpoints (#11331)

* Fix reverse-proxy caching in public fetch mode

* Fix caching in ActivityPub-specific controllers
master
ThibG 5 years ago committed by Eugen Rochko
parent 91544a6cb5
commit 15ddabf95a
  1. 9
      app/controllers/activitypub/base_controller.rb
  2. 2
      app/controllers/activitypub/collections_controller.rb
  3. 2
      app/controllers/activitypub/outboxes_controller.rb
  4. 2
      app/controllers/activitypub/replies_controller.rb
  5. 2
      app/controllers/application_controller.rb

@ -0,0 +1,9 @@
# frozen_string_literal: true
class ActivityPub::BaseController < Api::BaseController
private
def set_cache_headers
response.headers['Vary'] = 'Signature' if authorized_fetch_mode?
end
end

@ -1,6 +1,6 @@
# frozen_string_literal: true
class ActivityPub::CollectionsController < Api::BaseController
class ActivityPub::CollectionsController < ActivityPub::BaseController
include SignatureVerification
include AccountOwnedConcern

@ -1,6 +1,6 @@
# frozen_string_literal: true
class ActivityPub::OutboxesController < Api::BaseController
class ActivityPub::OutboxesController < ActivityPub::BaseController
LIMIT = 20
include SignatureVerification

@ -1,6 +1,6 @@
# frozen_string_literal: true
class ActivityPub::RepliesController < Api::BaseController
class ActivityPub::RepliesController < ActivityPub::BaseController
include SignatureAuthentication
include Authorization
include AccountOwnedConcern

@ -160,6 +160,6 @@ class ApplicationController < ActionController::Base
end
def set_cache_headers
response.headers['Vary'] = 'Accept, Signature'
response.headers['Vary'] = public_fetch_mode? ? 'Accept' : 'Accept, Signature'
end
end

Loading…
Cancel
Save